Horton

Re: remove unnecessary table_open/close from makeArrayTypeName

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-12-18T22:22:06Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Commit bc8036fc666a (12 years ago) seems to have introduced an
> unnecessary catalog heap_open/close in order to do syscache accesses.

Huh.  Not sure how that got past me, but I agree it's bogus.

> I presume a preliminary version of the patch used sysscans or something.
> I don't think that's necessary, so this patch removes it.

+1, but please collapse up the whitespace too.

			regards, tom lane

Commits

  1. makeArrayTypeName: Remove pointless relation open/close

  2. Support arrays of composite types, including the rowtypes of regular tables