Horton

Thread

Commits

  1. Fix some inconsistencies in MSVC scripts

  1. Comment fix of config_default.pl

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2019-07-12T03:15:29Z

    Hello.

In src/tools/msvc/config_default.pl, peremeter "perl" requires a
path string, not a bool differently from that of configure
script. --with-python has the same characteristics and the
comment is suggesting that.

We need to fix --with-perl and --with-uuid the same way.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  2. Re: Comment fix of config_default.pl

    Michael Paquier <michael@paquier.xyz> — 2019-07-12T04:01:13Z

    On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote:
> In src/tools/msvc/config_default.pl, parameter "perl" requires a
> path string, not a bool differently from that of configure
> script. --with-python has the same characteristics and the
> comment is suggesting that.
> 
> We need to fix --with-perl and --with-uuid the same way.
>
> +	uuid      => undef,    # --with-ossp-uuid=<path>

--with-ossp-uuid is an obsolete spelling.  Wouldn't it be better to
replace it with --with-uuid=<path>?  That would be a bit inconsistent
with configure which can only take a set of hardcoded names, still
there is little point in keeping an option which would get removed
sooner than later?
--
Michael

  3. Re: Comment fix of config_default.pl

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2019-07-12T06:34:11Z

    Thanks.

At Fri, 12 Jul 2019 13:01:13 +0900, Michael Paquier <michael@paquier.xyz> wrote in <20190712040113.GD2149@paquier.xyz>
> On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote:
> > In src/tools/msvc/config_default.pl, parameter "perl" requires a
> > path string, not a bool differently from that of configure
> > script. --with-python has the same characteristics and the
> > comment is suggesting that.
> > 
> > We need to fix --with-perl and --with-uuid the same way.
> >
> > +	uuid      => undef,    # --with-ossp-uuid=<path>
> 
> --with-ossp-uuid is an obsolete spelling.  Wouldn't it be better to
> replace it with --with-uuid=<path>?  That would be a bit inconsistent

Oops! Right. My eyes slipped over the difference..

> with configure which can only take a set of hardcoded names, still
> there is little point in keeping an option which would get removed
> sooner than later?

Agreed. Attached the fixed version.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  4. Re: Comment fix of config_default.pl

    Michael Paquier <michael@paquier.xyz> — 2019-07-12T08:01:41Z

    On Fri, Jul 12, 2019 at 03:34:11PM +0900, Kyotaro Horiguchi wrote:
> At Fri, 12 Jul 2019 13:01:13 +0900, Michael Paquier <michael@paquier.xyz> wrote in <20190712040113.GD2149@paquier.xyz>
>> --with-ossp-uuid is an obsolete spelling.  Wouldn't it be better to
>> replace it with --with-uuid=<path>?  That would be a bit inconsistent
> 
> Oops! Right. My eyes slipped over the difference..

I would also patch GetFakeConfigure in Solution.pm (no need to send a
new patch), and I thought that you'd actually do the change.  What do
you think?
--
Michael

  5. Re: Comment fix of config_default.pl

    Michael Paquier <michael@paquier.xyz> — 2019-07-13T07:53:45Z

    On Fri, Jul 12, 2019 at 05:01:41PM +0900, Michael Paquier wrote:
> I would also patch GetFakeConfigure in Solution.pm (no need to send a
> new patch), and I thought that you'd actually do the change.  What do
> you think?

OK, applied as I have been able to look at it again, and after fixing
the portion for GetFakeConfigure.  Thanks! 
--
Michael

  6. Re: Comment fix of config_default.pl

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2019-07-16T09:16:40Z

    At Sat, 13 Jul 2019 16:53:45 +0900, Michael Paquier <michael@paquier.xyz> wrote in <20190713075345.GC2137@paquier.xyz>
> On Fri, Jul 12, 2019 at 05:01:41PM +0900, Michael Paquier wrote:
> > I would also patch GetFakeConfigure in Solution.pm (no need to send a
> > new patch), and I thought that you'd actually do the change.  What do
> > you think?
> 
> OK, applied as I have been able to look at it again, and after fixing
> the portion for GetFakeConfigure.  Thanks! 

Thanks for committing and your additional part.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center