Re: Comment fix of config_default.pl
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-07-12T04:01:13Z
Lists: pgsql-hackers
On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote: > In src/tools/msvc/config_default.pl, parameter "perl" requires a > path string, not a bool differently from that of configure > script. --with-python has the same characteristics and the > comment is suggesting that. > > We need to fix --with-perl and --with-uuid the same way. > > + uuid => undef, # --with-ossp-uuid=<path> --with-ossp-uuid is an obsolete spelling. Wouldn't it be better to replace it with --with-uuid=<path>? That would be a bit inconsistent with configure which can only take a set of hardcoded names, still there is little point in keeping an option which would get removed sooner than later? -- Michael
Commits
-
Fix some inconsistencies in MSVC scripts
- 39aadc984221 13.0 landed