Re: Comment fix of config_default.pl

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: michael@paquier.xyz
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-07-12T06:34:11Z
Lists: pgsql-hackers

Attachments

Thanks.

At Fri, 12 Jul 2019 13:01:13 +0900, Michael Paquier <michael@paquier.xyz> wrote in <20190712040113.GD2149@paquier.xyz>
> On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote:
> > In src/tools/msvc/config_default.pl, parameter "perl" requires a
> > path string, not a bool differently from that of configure
> > script. --with-python has the same characteristics and the
> > comment is suggesting that.
> > 
> > We need to fix --with-perl and --with-uuid the same way.
> >
> > +	uuid      => undef,    # --with-ossp-uuid=<path>
> 
> --with-ossp-uuid is an obsolete spelling.  Wouldn't it be better to
> replace it with --with-uuid=<path>?  That would be a bit inconsistent

Oops! Right. My eyes slipped over the difference..

> with configure which can only take a set of hardcoded names, still
> there is little point in keeping an option which would get removed
> sooner than later?

Agreed. Attached the fixed version.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Fix some inconsistencies in MSVC scripts