Horton

Thread

Commits

  1. pgcrypto: Remove explicit hex encoding/decoding from tests

  1. pgcrypto: Remove explicit hex encoding/decoding from tests

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2021-12-02T09:22:49Z

    pgcrypto tests use encode() and decode() calls to convert to/from hex 
encoding.  This was from before the hex format was available in bytea. 
Now we can remove the extra explicit encoding/decoding calls and rely on 
the default output format.

  2. Re: pgcrypto: Remove explicit hex encoding/decoding from tests

    Daniel Gustafsson <daniel@yesql.se> — 2021-12-02T09:46:46Z

    > On 2 Dec 2021, at 10:22, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:

> pgcrypto tests use encode() and decode() calls to convert to/from hex encoding.  This was from before the hex format was available in bytea. Now we can remove the extra explicit encoding/decoding calls and rely on the default output format.

My eyes glazed over a bit but definitely a +1 on the idea.

--
Daniel Gustafsson		https://vmware.com/

  3. Re: pgcrypto: Remove explicit hex encoding/decoding from tests

    Tom Lane <tgl@sss.pgh.pa.us> — 2021-12-02T18:30:45Z

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> pgcrypto tests use encode() and decode() calls to convert to/from hex 
> encoding.  This was from before the hex format was available in bytea. 
> Now we can remove the extra explicit encoding/decoding calls and rely on 
> the default output format.

Generally +1, but I see you removed some instances of

--- ensure consistent test output regardless of the default bytea format
-SET bytea_output TO escape;

I think that the principle still applies that this should work regardless
of the installation's default bytea format, so I'd recommend putting

-- ensure consistent test output regardless of the default bytea format
SET bytea_output TO hex;

at the top of each file instead.

			regards, tom lane

  4. Re: pgcrypto: Remove explicit hex encoding/decoding from tests

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2021-12-03T15:48:07Z

    On 02.12.21 19:30, Tom Lane wrote:
> Generally +1, but I see you removed some instances of
> 
> --- ensure consistent test output regardless of the default bytea format
> -SET bytea_output TO escape;
> 
> I think that the principle still applies that this should work regardless
> of the installation's default bytea format, so I'd recommend putting
> 
> -- ensure consistent test output regardless of the default bytea format
> SET bytea_output TO hex;
> 
> at the top of each file instead.

pg_regress.c sets bytea_output to hex already.

  5. Re: pgcrypto: Remove explicit hex encoding/decoding from tests

    Tom Lane <tgl@sss.pgh.pa.us> — 2021-12-03T15:50:10Z

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> pg_regress.c sets bytea_output to hex already.

Ah, right.  Nevermind that then.

			regards, tom lane