Re: pgcrypto: Remove explicit hex encoding/decoding from tests
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-12-02T18:30:45Z
Lists: pgsql-hackers
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes: > pgcrypto tests use encode() and decode() calls to convert to/from hex > encoding. This was from before the hex format was available in bytea. > Now we can remove the extra explicit encoding/decoding calls and rely on > the default output format. Generally +1, but I see you removed some instances of --- ensure consistent test output regardless of the default bytea format -SET bytea_output TO escape; I think that the principle still applies that this should work regardless of the installation's default bytea format, so I'd recommend putting -- ensure consistent test output regardless of the default bytea format SET bytea_output TO hex; at the top of each file instead. regards, tom lane
Commits
-
pgcrypto: Remove explicit hex encoding/decoding from tests
- 814e1d9ff7a8 15.0 landed