Re: pgcrypto: Remove explicit hex encoding/decoding from tests

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-12-03T15:48:07Z
Lists: pgsql-hackers
On 02.12.21 19:30, Tom Lane wrote:
> Generally +1, but I see you removed some instances of
> 
> --- ensure consistent test output regardless of the default bytea format
> -SET bytea_output TO escape;
> 
> I think that the principle still applies that this should work regardless
> of the installation's default bytea format, so I'd recommend putting
> 
> -- ensure consistent test output regardless of the default bytea format
> SET bytea_output TO hex;
> 
> at the top of each file instead.

pg_regress.c sets bytea_output to hex already.



Commits

  1. pgcrypto: Remove explicit hex encoding/decoding from tests