Thread
Commits
-
Fix error message related to end TLI in backup manifest
- f1dc7a5b7609 14.21 landed
- fbf8df580aeb 15.16 landed
- e8fd6c9fdaf6 16.12 landed
- 05ef2371a3f0 17.8 landed
- 69ee81932a16 18.2 landed
- 6bca4b50d000 19 (unreleased) landed
-
[PATCH] backup: Fix trivial typo and error message issues
zengman <zengman@halodbtech.com> — 2026-01-15T13:02:42Z
Hi all, I noticed two trivial issues in backup-related code: 1. backup_manifest.c: The timeline mismatch error message uses `starttli` instead of `endtli`. 2. basebackup_copy.c: There is a spelling error (sine → since) in the comment above the `PROGRESS_REPORT_BYTE_INTERVAL` macro. ``` --- a/src/backend/backup/backup_manifest.c +++ b/src/backend/backup/backup_manifest.c @@ -253,7 +253,7 @@ AddWALInfoToBackupManifest(backup_manifest_info *manifest, XLogRecPtr startptr, if (first_wal_range && endtli != entry->tli) ereport(ERROR, errmsg("expected end timeline %u but found timeline %u", - starttli, entry->tli)); + endtli, entry->tli)); ``` ``` - * So we only check it after the number of bytes sine the last check reaches + * So we only check it after the number of bytes since the last check reaches ``` -- Regards, Man Zeng www.openhalo.org -
Re: [PATCH] backup: Fix trivial typo and error message issues
Steven Niu <niushiji@gmail.com> — 2026-01-15T14:20:36Z
From: zengman <zengman@halodbtech.com> Sent: Thursday, January 15, 2026 21:02 To: pgsql-hackers <pgsql-hackers@lists.postgresql.org> Subject: [PATCH] backup: Fix trivial typo and error message issues Hi all, I noticed two trivial issues in backup-related code: 1. backup_manifest.c: The timeline mismatch error message uses `starttli` instead of `endtli`. 2. basebackup_copy.c: There is a spelling error (sine → since) in the comment above the `PROGRESS_REPORT_BYTE_INTERVAL` macro. ``` --- a/src/backend/backup/backup_manifest.c +++ b/src/backend/backup/backup_manifest.c @@ -253,7 +253,7 @@ AddWALInfoToBackupManifest(backup_manifest_info *manifest, XLogRecPtr startptr, if (first_wal_range && endtli != entry->tli) ereport(ERROR, errmsg("expected end timeline %u but found timeline %u", - starttli, entry->tli)); + endtli, entry->tli)); ``` ``` - * So we only check it after the number of bytes sine the last check reaches + * So we only check it after the number of bytes since the last check reaches ``` -- Regards, Man Zeng www.openhalo.org ________________________________________ Nice catch! Agree that the expected end timeline should be endtli instead of starttli per the comments above the code. And the "sine" is obviously a typo. Regards, Steven -
Re: [PATCH] backup: Fix trivial typo and error message issues
Aditya Gollamudi <adigollamudi@gmail.com> — 2026-01-17T20:22:54Z
On Thu, Jan 15, 2026 at 6:20 AM Steven Niu <niushiji@gmail.com> wrote: > From: zengman <zengman@halodbtech.com> > Sent: Thursday, January 15, 2026 21:02 > To: pgsql-hackers <pgsql-hackers@lists.postgresql.org> > Subject: [PATCH] backup: Fix trivial typo and error message issues > > > Hi all, > > I noticed two trivial issues in backup-related code: > 1. backup_manifest.c: The timeline mismatch error message uses `starttli` > instead of `endtli`. > 2. basebackup_copy.c: There is a spelling error (sine → since) in the > comment above the `PROGRESS_REPORT_BYTE_INTERVAL` macro. > > ``` > --- a/src/backend/backup/backup_manifest.c > +++ b/src/backend/backup/backup_manifest.c > @@ -253,7 +253,7 @@ AddWALInfoToBackupManifest(backup_manifest_info > *manifest, XLogRecPtr startptr, > if (first_wal_range && endtli != entry->tli) > ereport(ERROR, > errmsg("expected end timeline %u > but found timeline %u", > - starttli, entry->tli)); > + endtli, entry->tli)); > ``` > > ``` > - * So we only check it after the number of bytes sine the last check > reaches > + * So we only check it after the number of bytes since the last check > reaches > ``` > > -- > Regards, > Man Zeng > www.openhalo.org > > > ________________________________________ > > Nice catch! Agree that the expected end timeline should be endtli instead > of starttli per the comments above the code. > > And the "sine" is obviously a typo. > > Regards, > Steven Patch applies cleanly on current master and builds without issues! I ran make check successfully. I agree that endtli makes more sense here, and thanks for fixing the typo. Note: I wasn’t able to get make installcheck to run cleanly due to local environment issues, which appear unrelated to this patch. - Adi Gollamudi -
Re: [PATCH] backup: Fix trivial typo and error message issues
Michael Paquier <michael@paquier.xyz> — 2026-01-18T07:20:54Z
On Sat, Jan 17, 2026 at 12:22:54PM -0800, Aditya Gollamudi wrote: > Patch applies cleanly on current master and builds without issues! > > I ran make check successfully. I agree that endtli makes more sense here, > and thanks for fixing the typo. I am parking the typo for later. We had better backpatch the error message part as it could lead to an incorrect analysis when should AddWALInfoToBackupManifest() blurp. Will do that in a bit. -- Michael
-
Re: [PATCH] backup: Fix trivial typo and error message issues
zengman <zengman@halodbtech.com> — 2026-01-18T11:40:02Z
> I am parking the typo for later. We had better backpatch the error > message part as it could lead to an incorrect analysis when should > AddWALInfoToBackupManifest() blurp. Will do that in a bit. Thanks for handling this patch. Thanks to everyone. -- Regards, Man Zeng www.openhalo.org