[PATCH] backup: Fix trivial typo and error message issues
zengman <zengman@halodbtech.com>
From: zengman <zengman@halodbtech.com>
To: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-01-15T13:02:42Z
Lists: pgsql-hackers
Attachments
- 0001-Update-error-message-in-AddWALInfoToBackupManifest-f.patch (application/octet-stream) patch 0001
Hi all,
I noticed two trivial issues in backup-related code:
1. backup_manifest.c: The timeline mismatch error message uses `starttli` instead of `endtli`.
2. basebackup_copy.c: There is a spelling error (sine → since) in the comment above the `PROGRESS_REPORT_BYTE_INTERVAL` macro.
```
--- a/src/backend/backup/backup_manifest.c
+++ b/src/backend/backup/backup_manifest.c
@@ -253,7 +253,7 @@ AddWALInfoToBackupManifest(backup_manifest_info *manifest, XLogRecPtr startptr,
if (first_wal_range && endtli != entry->tli)
ereport(ERROR,
errmsg("expected end timeline %u but found timeline %u",
- starttli, entry->tli));
+ endtli, entry->tli));
```
```
- * So we only check it after the number of bytes sine the last check reaches
+ * So we only check it after the number of bytes since the last check reaches
```
--
Regards,
Man Zeng
www.openhalo.org
Commits
-
Fix error message related to end TLI in backup manifest
- f1dc7a5b7609 14.21 landed
- fbf8df580aeb 15.16 landed
- e8fd6c9fdaf6 16.12 landed
- 05ef2371a3f0 17.8 landed
- 69ee81932a16 18.2 landed
- 6bca4b50d000 19 (unreleased) landed