Horton

Thread

Commits

  1. Fix pgstat_report_replslot() to use proper data types for its arguments.

  1. Data type correction in pgstat_report_replslot function parameters

    vignesh C <vignesh21@gmail.com> — 2021-04-01T16:49:54Z

    Hi,

While I was reviewing replication slot statistics code, I found one
issue in the data type used for pgstat_report_replslot function
parameters. We pass int64 variables to the function but the function
prototype uses int type. I I felt the function parameters should be
int64. Attached patch fixes the same.
Thoughts?

Regards,
Vignesh

  2. Re: Data type correction in pgstat_report_replslot function parameters

    Jeevan Ladhe <jeevan.ladhe@enterprisedb.com> — 2021-04-01T17:18:07Z

    On Thu, Apr 1, 2021 at 10:20 PM vignesh C <vignesh21@gmail.com> wrote:

> Hi,
>
> While I was reviewing replication slot statistics code, I found one
> issue in the data type used for pgstat_report_replslot function
> parameters. We pass int64 variables to the function but the function
> prototype uses int type. I I felt the function parameters should be
> int64. Attached patch fixes the same.


+1 for the change. The patch LGTM.

Regards,
Jeevan Ladhe

  3. Re: Data type correction in pgstat_report_replslot function parameters

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-04-01T17:48:34Z

    
On 2021/04/02 2:18, Jeevan Ladhe wrote:
> 
> 
> On Thu, Apr 1, 2021 at 10:20 PM vignesh C <vignesh21@gmail.com <mailto:vignesh21@gmail.com>> wrote:
> 
>     Hi,
> 
>     While I was reviewing replication slot statistics code, I found one
>     issue in the data type used for pgstat_report_replslot function
>     parameters. We pass int64 variables to the function but the function
>     prototype uses int type. I I felt the function parameters should be
>     int64. Attached patch fixes the same.

Isn't it better to use PgStat_Counter instead of int64?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  4. Re: Data type correction in pgstat_report_replslot function parameters

    vignesh C <vignesh21@gmail.com> — 2021-04-02T02:20:48Z

    On Thu, Apr 1, 2021 at 11:18 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>
>
>
> On 2021/04/02 2:18, Jeevan Ladhe wrote:
> >
> >
> > On Thu, Apr 1, 2021 at 10:20 PM vignesh C <vignesh21@gmail.com <mailto:vignesh21@gmail.com>> wrote:
> >
> >     Hi,
> >
> >     While I was reviewing replication slot statistics code, I found one
> >     issue in the data type used for pgstat_report_replslot function
> >     parameters. We pass int64 variables to the function but the function
> >     prototype uses int type. I I felt the function parameters should be
> >     int64. Attached patch fixes the same.
>
> Isn't it better to use PgStat_Counter instead of int64?
>

Thanks for your comment, the updated patch contains the changes for it.

Regards,
Vignesh

  5. Re: Data type correction in pgstat_report_replslot function parameters

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-04-02T08:29:26Z

    
On 2021/04/02 11:20, vignesh C wrote:
> On Thu, Apr 1, 2021 at 11:18 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>>
>>
>> On 2021/04/02 2:18, Jeevan Ladhe wrote:
>>>
>>>
>>> On Thu, Apr 1, 2021 at 10:20 PM vignesh C <vignesh21@gmail.com <mailto:vignesh21@gmail.com>> wrote:
>>>
>>>      Hi,
>>>
>>>      While I was reviewing replication slot statistics code, I found one
>>>      issue in the data type used for pgstat_report_replslot function
>>>      parameters. We pass int64 variables to the function but the function
>>>      prototype uses int type. I I felt the function parameters should be
>>>      int64. Attached patch fixes the same.
>>
>> Isn't it better to use PgStat_Counter instead of int64?
>>
> 
> Thanks for your comment, the updated patch contains the changes for it.

Thanks for updating the patch! Pushed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  6. Re: Data type correction in pgstat_report_replslot function parameters

    vignesh C <vignesh21@gmail.com> — 2021-04-03T01:38:57Z

    On Fri, Apr 2, 2021 at 1:59 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>
>
>
> On 2021/04/02 11:20, vignesh C wrote:
> > On Thu, Apr 1, 2021 at 11:18 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> >>
> >>
> >>
> >> On 2021/04/02 2:18, Jeevan Ladhe wrote:
> >>>
> >>>
> >>> On Thu, Apr 1, 2021 at 10:20 PM vignesh C <vignesh21@gmail.com <mailto:vignesh21@gmail.com>> wrote:
> >>>
> >>>      Hi,
> >>>
> >>>      While I was reviewing replication slot statistics code, I found one
> >>>      issue in the data type used for pgstat_report_replslot function
> >>>      parameters. We pass int64 variables to the function but the function
> >>>      prototype uses int type. I I felt the function parameters should be
> >>>      int64. Attached patch fixes the same.
> >>
> >> Isn't it better to use PgStat_Counter instead of int64?
> >>
> >
> > Thanks for your comment, the updated patch contains the changes for it.
>
> Thanks for updating the patch! Pushed.

Thanks for pushing.

Regards,
Vignesh