Horton

Thread

Commits

  1. Apply PGDLLIMPORT markings to some GUC variables

  2. Move extern declarations for EXEC_BACKEND to header files

  1. Apply PGDLLIMPORT markings to some GUC variables

    Sofia Kopikova <s.kopikova@postgrespro.ru> — 2024-08-13T14:38:42Z

    Hi hackers,

I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
header files. According to the commit message in 8ec569479, all
variables in header files must be marked with PGDLLIMPORT, am I right?

I've made a patch that adds missing PGDLLIMPORTs, please, take a look.

--
Best regards,
Sofia Kopikova
Postgres Professional: http://www.postgrespro.com

  2. Re: Apply PGDLLIMPORT markings to some GUC variables

    Robert Haas <robertmhaas@gmail.com> — 2024-08-13T19:00:00Z

    On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
<s.kopikova@postgrespro.ru> wrote:
> I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
> header files. According to the commit message in 8ec569479, all
> variables in header files must be marked with PGDLLIMPORT, am I right?
>
> I've made a patch that adds missing PGDLLIMPORTs, please, take a look.

This seems correct to me.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

  3. Re: Apply PGDLLIMPORT markings to some GUC variables

    Peter Eisentraut <peter@eisentraut.org> — 2024-08-14T09:50:08Z

    On 13.08.24 21:00, Robert Haas wrote:
> On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
> <s.kopikova@postgrespro.ru> wrote:
>> I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
>> header files. According to the commit message in 8ec569479, all
>> variables in header files must be marked with PGDLLIMPORT, am I right?
>>
>> I've made a patch that adds missing PGDLLIMPORTs, please, take a look.
> 
> This seems correct to me.

committed

  4. Re: Apply PGDLLIMPORT markings to some GUC variables

    Sofia Kopikova <s.kopikova@postgrespro.ru> — 2024-08-14T10:14:48Z

    On 8/14/24 12:50, Peter Eisentraut wrote:
> On 13.08.24 21:00, Robert Haas wrote:
>> On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
>> <s.kopikova@postgrespro.ru> wrote:
>>> I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
>>> header files. According to the commit message in 8ec569479, all
>>> variables in header files must be marked with PGDLLIMPORT, am I right?
>>>
>>> I've made a patch that adds missing PGDLLIMPORTs, please, take a look.
>>
>> This seems correct to me.
>
> committed
>
Many thanks for quick review and commit.

-- 
Best regards,
Sofia Kopikova
Postgres Professional: http://www.postgrespro.com

  5. Re: Apply PGDLLIMPORT markings to some GUC variables

    Michael Paquier <michael@paquier.xyz> — 2024-08-19T06:18:20Z

    On Tue, Aug 13, 2024 at 03:00:00PM -0400, Robert Haas wrote:
> This seems correct to me.

It is not the first time that this happens in recent history.  Would
it be worth automating that?  I would guess a TAP test that takes a
copy of the headers, applies the changes while filtering the few
exceptions, then compares it to the origin in the tree?
--
Michael

  6. Re: Apply PGDLLIMPORT markings to some GUC variables

    Peter Eisentraut <peter@eisentraut.org> — 2024-08-19T09:20:33Z

    On 19.08.24 08:18, Michael Paquier wrote:
> On Tue, Aug 13, 2024 at 03:00:00PM -0400, Robert Haas wrote:
>> This seems correct to me.
> 
> It is not the first time that this happens in recent history.  Would
> it be worth automating that?  I would guess a TAP test that takes a
> copy of the headers, applies the changes while filtering the few
> exceptions, then compares it to the origin in the tree?

Probably worth thinking about, but it would at least require some kind 
of exclude list, because there are exceptions like src/include/common/ 
/logging.h.