Re: Apply PGDLLIMPORT markings to some GUC variables

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Robert Haas <robertmhaas@gmail.com>, Sofia Kopikova <s.kopikova@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org
Date: 2024-08-14T09:50:08Z
Lists: pgsql-hackers
On 13.08.24 21:00, Robert Haas wrote:
> On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
> <s.kopikova@postgrespro.ru> wrote:
>> I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
>> header files. According to the commit message in 8ec569479, all
>> variables in header files must be marked with PGDLLIMPORT, am I right?
>>
>> I've made a patch that adds missing PGDLLIMPORTs, please, take a look.
> 
> This seems correct to me.

committed




Commits

  1. Apply PGDLLIMPORT markings to some GUC variables

  2. Move extern declarations for EXEC_BACKEND to header files