Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix error of pg_stat_reset_shared()

  1. Fix the error hint message and test for reset_shared with unknown stats type

    Maksim Logvinenko <logvinenko-ms@yandex.ru> — 2026-04-28T15:13:11Z

    <div><div><div>Hi hackers,</div><div> </div><div>The errhint() in pg_stat_reset_shared() were missing the fact that recently added in [1] new lock stats kind.</div><div>The patch fixes error hint message and regress test for reset_shared with unknown stats type.</div><div> </div><div>[1]: https://www.postgresql.org/message-id/aIyNxBWFCybgBZBS%40ip-10-97-1-34.eu-west-3.compute.internal</div><div> </div><div>Best regards,</div><div>Maksim Logvinenko</div><div>Postgres Professional: http://postgrespro.com</div></div></div>

  2. Re: Fix the error hint message and test for reset_shared with unknown stats type

    Maksim Logvinenko <logvinenko-ms@yandex.ru> — 2026-04-28T15:18:21Z

       


  I'm sorry for the forgotten patch in the attachment


  ----------------


  Кому: pgsql-hackers@lists.postgresql.org (pgsql-hackers@lists.postgresql.org);


  Тема: Fix the error hint message and test for reset_shared with unknown stats type;


  28.04.2026, 20:13, "Maksim Logvinenko" <logvinenko-ms@yandex.ru>:


  
    
      Hi hackers,
    
    
       
    
    
      The errhint() in pg_stat_reset_shared() were missing the fact that recently added in [1] new lock stats kind.
    
    
      The patch fixes error hint message and regress test for reset_shared with unknown stats type.
    
    
       
    
    
      [1]: https://www.postgresql.org/message-id/aIyNxBWFCybgBZBS%40ip-10-97-1-34.eu-west-3.compute.internal
    
    
       
    
    
      Best regards,
    
    
      Maksim Logvinenko
    
    
      Postgres Professional: http://postgrespro.com

  3. Re: Fix the error hint message and test for reset_shared with unknown stats type

    Michael Paquier <michael@paquier.xyz> — 2026-04-28T23:12:04Z

    On Tue, Apr 28, 2026 at 08:18:21PM +0500, Maksim Logvinenko wrote:
> The existing error hint message and test were missing the fact that
> recently added new lock stats kind.
>
> @@ -1987,7 +1987,7 @@ pg_stat_reset_shared(PG_FUNCTION_ARGS)
>  		ereport(ERROR,
>  				(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>  				 errmsg("unrecognized reset target: \"%s\"", target),
> -				 errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"recovery_prefetch\", \"slru\", or \"wal\".")));
> +				 errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"lock\", \"recovery_prefetch\", \"slru\", or \"wal\".")));

Right, thanks for the report, Maksim.  I'll fix it later.
--
Michael

  4. Re: Fix the error hint message and test for reset_shared with unknown stats type

    Michael Paquier <michael@paquier.xyz> — 2026-04-30T02:33:35Z

    On Wed, Apr 29, 2026 at 08:12:04AM +0900, Michael Paquier wrote:
> Right, thanks for the report, Maksim.  I'll fix it later.

And done.
--
Michael