Horton
Menu

Re: Fix the error hint message and test for reset_shared with unknown stats type

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Maksim Logvinenko <logvinenko-ms@yandex.ru>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-28T23:12:04Z
Lists: pgsql-hackers 
On Tue, Apr 28, 2026 at 08:18:21PM +0500, Maksim Logvinenko wrote:
> The existing error hint message and test were missing the fact that
> recently added new lock stats kind.
>
> @@ -1987,7 +1987,7 @@ pg_stat_reset_shared(PG_FUNCTION_ARGS)
>  		ereport(ERROR,
>  				(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>  				 errmsg("unrecognized reset target: \"%s\"", target),
> -				 errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"recovery_prefetch\", \"slru\", or \"wal\".")));
> +				 errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"lock\", \"recovery_prefetch\", \"slru\", or \"wal\".")));

Right, thanks for the report, Maksim.  I'll fix it later.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix error of pg_stat_reset_shared()