Horton

Thread

Commits

  1. Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT

  2. Use PRI?64 instead of "ll?" in format strings (continued).

  3. Add INT64_HEX_FORMAT and UINT64_HEX_FORMAT to c.h.

  1. Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT

    Peter Eisentraut <peter@eisentraut.org> — 2025-08-02T09:09:16Z

    These were introduced (commit efdc7d74753) at the same time as we were 
moving to using the standard inttypes.h format macros (commit 
a0ed19e0a9e).  It doesn't seem useful to keep a new already-deprecated 
interface like this with only a few users, so remove the new symbols 
again and have the callers use PRIx64.

(Also, INT64_HEX_FORMAT was kind of a misnomer, since hex formats all 
use unsigned types.)

[should be backpatched to PG18]

  2. Re: Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT

    Nathan Bossart <nathandbossart@gmail.com> — 2025-08-02T18:25:30Z

    On Sat, Aug 02, 2025 at 11:09:16AM +0200, Peter Eisentraut wrote:
> These were introduced (commit efdc7d74753) at the same time as we were
> moving to using the standard inttypes.h format macros (commit a0ed19e0a9e).
> It doesn't seem useful to keep a new already-deprecated interface like this
> with only a few users, so remove the new symbols again and have the callers
> use PRIx64.

That seems fine to me.

-- 
nathan

  3. Re: Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT

    Thomas Munro <thomas.munro@gmail.com> — 2025-08-04T03:03:20Z

    On Sun, Aug 3, 2025 at 6:25 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
> On Sat, Aug 02, 2025 at 11:09:16AM +0200, Peter Eisentraut wrote:
> > These were introduced (commit efdc7d74753) at the same time as we were
> > moving to using the standard inttypes.h format macros (commit a0ed19e0a9e).
> > It doesn't seem useful to keep a new already-deprecated interface like this
> > with only a few users, so remove the new symbols again and have the callers
> > use PRIx64.
>
> That seems fine to me.

+1

  4. Re: Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT

    Peter Eisentraut <peter@eisentraut.org> — 2025-08-06T09:09:35Z

    On 04.08.25 05:03, Thomas Munro wrote:
> On Sun, Aug 3, 2025 at 6:25 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> On Sat, Aug 02, 2025 at 11:09:16AM +0200, Peter Eisentraut wrote:
>>> These were introduced (commit efdc7d74753) at the same time as we were
>>> moving to using the standard inttypes.h format macros (commit a0ed19e0a9e).
>>> It doesn't seem useful to keep a new already-deprecated interface like this
>>> with only a few users, so remove the new symbols again and have the callers
>>> use PRIx64.
>>
>> That seems fine to me.
> 
> +1

done