Horton

Thread

Commits

  1. Improve style of pg_upgrade task callback functions.

  2. Remove extra whitespace in pg_upgrade status message.

  3. Introduce framework for parallelizing various pg_upgrade tasks.

  4. pg_upgrade: run all data type checks per connection

  1. miscellaneous pg_upgrade cleanup

    Nathan Bossart <nathandbossart@gmail.com> — 2024-09-17T19:22:21Z

    Here are a few miscellaneous cleanup patches for pg_upgrade.  I don't think
there's anything controversial here.

0001 removes some extra whitespace in the status message for failed data
type checks.  I noticed that when the check fails, this status message is
indented beyond all the other output.  This appears to have been introduced
in commit 347758b, so I'd back-patch this one to v17.

0002 improves the coding style in many of the new upgrade task callback
functions.  I refrained from adjusting this code too much when converting
these tasks to use the new pg_upgrade task framework (see commit 40e2e5e),
but now I think we should.  This decreases the amount of indentation in
some places and removes a few dozen lines of code.

0003 adds names to the UpgradeTaskSlotState enum and the UpgradeTaskSlot
struct.  I'm not aware of any established project policy in this area, but
I figured it'd be good to at least be consistent within the same file.

Thoughts?

-- 
nathan

  2. Re: miscellaneous pg_upgrade cleanup

    Daniel Gustafsson <daniel@yesql.se> — 2024-09-23T13:04:22Z

    > On 17 Sep 2024, at 21:22, Nathan Bossart <nathandbossart@gmail.com> wrote:
> 
> Here are a few miscellaneous cleanup patches for pg_upgrade.  I don't think
> there's anything controversial here.

No objections to any of these changes, LGTM.

--
Daniel Gustafsson

  3. Re: miscellaneous pg_upgrade cleanup

    Nathan Bossart <nathandbossart@gmail.com> — 2024-09-23T14:06:03Z

    On Mon, Sep 23, 2024 at 03:04:22PM +0200, Daniel Gustafsson wrote:
> No objections to any of these changes, LGTM.

Thanks for reviewing.  I'll commit these once the v17 release freeze is
over (since 0001 needs to be back-patched there).

-- 
nathan

  4. Re: miscellaneous pg_upgrade cleanup

    Nathan Bossart <nathandbossart@gmail.com> — 2024-09-26T18:58:24Z

    Committed.

-- 
nathan