miscellaneous pg_upgrade cleanup
Nathan Bossart <nathandbossart@gmail.com>
From: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Cc: daniel@yesql.se
Date: 2024-09-17T19:22:21Z
Lists: pgsql-hackers
Attachments
Here are a few miscellaneous cleanup patches for pg_upgrade. I don't think there's anything controversial here. 0001 removes some extra whitespace in the status message for failed data type checks. I noticed that when the check fails, this status message is indented beyond all the other output. This appears to have been introduced in commit 347758b, so I'd back-patch this one to v17. 0002 improves the coding style in many of the new upgrade task callback functions. I refrained from adjusting this code too much when converting these tasks to use the new pg_upgrade task framework (see commit 40e2e5e), but now I think we should. This decreases the amount of indentation in some places and removes a few dozen lines of code. 0003 adds names to the UpgradeTaskSlotState enum and the UpgradeTaskSlot struct. I'm not aware of any established project policy in this area, but I figured it'd be good to at least be consistent within the same file. Thoughts? -- nathan
Commits
-
Improve style of pg_upgrade task callback functions.
- 9726653185de 18.0 landed
-
Remove extra whitespace in pg_upgrade status message.
- 4e0864af16b5 17.1 landed
- 2ceeb638b7b2 18.0 landed
-
Introduce framework for parallelizing various pg_upgrade tasks.
- 40e2e5e92b7d 18.0 cited
-
pg_upgrade: run all data type checks per connection
- 347758b12063 17.0 cited