Horton

Thread

Commits

  1. Add pg_version() to PostgreSQL::Test::Cluster

  1. Addition of PostgreSQL::Test::Cluster::pg_version()

    Michael Paquier <michael@paquier.xyz> — 2022-05-19T01:38:40Z

    Hi all,
(Added Andrew in CC.)

While working more on expanding the tests of pg_upgrade for
cross-version checks, I have noticed that we don't expose a routine
able to get back _pg_version from a node, which should remain a
private field of Cluster.pm.  We already do that for install_path, as
of case added by 87076c4.

Any objections or comments about the addition of a routine to get the
PostgreSQL::Version, as of the attached?

Thanks,
--
Michael

  2. Re: Addition of PostgreSQL::Test::Cluster::pg_version()

    Daniel Gustafsson <daniel@yesql.se> — 2022-05-19T07:03:57Z

    > On 19 May 2022, at 03:38, Michael Paquier <michael@paquier.xyz> wrote:

> Any objections or comments about the addition of a routine to get the
> PostgreSQL::Version, as of the attached?

I haven't tested the patch, but +1 on the idea.

--
Daniel Gustafsson		https://vmware.com/

  3. Re: Addition of PostgreSQL::Test::Cluster::pg_version()

    Andrew Dunstan <andrew@dunslane.net> — 2022-05-19T11:28:53Z

    On 2022-05-18 We 21:38, Michael Paquier wrote:
> Hi all,
> (Added Andrew in CC.)
>
> While working more on expanding the tests of pg_upgrade for
> cross-version checks, I have noticed that we don't expose a routine
> able to get back _pg_version from a node, which should remain a
> private field of Cluster.pm.  We already do that for install_path, as
> of case added by 87076c4.
>
> Any objections or comments about the addition of a routine to get the
> PostgreSQL::Version, as of the attached?
>


Looks ok. PostgreSQL::Version is designed so that the object behaves
sanely in comparisons and when interpolated into a string.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

  4. Re: Addition of PostgreSQL::Test::Cluster::pg_version()

    Michael Paquier <michael@paquier.xyz> — 2022-05-20T00:54:22Z

    On Thu, May 19, 2022 at 07:28:53AM -0400, Andrew Dunstan wrote:
> Looks ok. PostgreSQL::Version is designed so that the object behaves
> sanely in comparisons and when interpolated into a string.

I saw that, and that's kind of nice when it comes to write
version-specific code paths in the tests ;) 
--
Michael

  5. Re: Addition of PostgreSQL::Test::Cluster::pg_version()

    Michael Paquier <michael@paquier.xyz> — 2022-05-20T10:51:00Z

    On Thu, May 19, 2022 at 07:28:53AM -0400, Andrew Dunstan wrote:
> Looks ok. PostgreSQL::Version is designed so that the object behaves
> sanely in comparisons and when interpolated into a string.

Okay, I have applied this thing.  I'll move back to my business with
the tests of pg_upgrade...
--
Michael