Re: Addition of PostgreSQL::Test::Cluster::pg_version()

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Michael Paquier <michael@paquier.xyz>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-05-19T11:28:53Z
Lists: pgsql-hackers
On 2022-05-18 We 21:38, Michael Paquier wrote:
> Hi all,
> (Added Andrew in CC.)
>
> While working more on expanding the tests of pg_upgrade for
> cross-version checks, I have noticed that we don't expose a routine
> able to get back _pg_version from a node, which should remain a
> private field of Cluster.pm.  We already do that for install_path, as
> of case added by 87076c4.
>
> Any objections or comments about the addition of a routine to get the
> PostgreSQL::Version, as of the attached?
>


Looks ok. PostgreSQL::Version is designed so that the object behaves
sanely in comparisons and when interpolated into a string.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




Commits

  1. Add pg_version() to PostgreSQL::Test::Cluster