Horton

Thread

Commits

  1. Remove unnecessary include of <math.h>

  2. Remove unnecessary include of <sys/socket.h>

  3. Remove unnecessary includes of <signal.h>

  1. Remove unnecessary includes of system headers in header files

    Peter Eisentraut <peter@eisentraut.org> — 2023-12-01T07:53:44Z

    I noticed that some header files included system header files for no 
apparent reason, so I did some digging and found out that in a few cases 
the original reason has disappeared.  So I propose the attached patches 
to remove the unnecessary includes.

  2. RE: Remove unnecessary includes of system headers in header files

    Shubham.Khanna@fujitsu.com <shubham.khanna@fujitsu.com> — 2023-12-01T10:51:39Z

    Hi Peter,

I have reviewed the patches and also RUN the command, 'make check-world'. It is working fine. All test cases are passed successfully.

Thanks and Regards,
Shubham Khanna.

-----Original Message-----
From: Peter Eisentraut <peter@eisentraut.org> 
Sent: Friday, December 1, 2023 1:24 PM
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Remove unnecessary includes of system headers in header files

I noticed that some header files included system header files for no apparent reason, so I did some digging and found out that in a few cases the original reason has disappeared.  So I propose the attached patches to remove the unnecessary includes.

  3. Re: Remove unnecessary includes of system headers in header files

    Tom Lane <tgl@sss.pgh.pa.us> — 2023-12-01T16:41:07Z

    Peter Eisentraut <peter@eisentraut.org> writes:
> I noticed that some header files included system header files for no 
> apparent reason, so I did some digging and found out that in a few cases 
> the original reason has disappeared.  So I propose the attached patches 
> to remove the unnecessary includes.

Seems generally reasonable.  Have you checked that headerscheck and
cpluspluscheck are happy?

			regards, tom lane

  4. Re: Remove unnecessary includes of system headers in header files

    Peter Eisentraut <peter@eisentraut.org> — 2023-12-02T08:39:05Z

    On 01.12.23 17:41, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> I noticed that some header files included system header files for no
>> apparent reason, so I did some digging and found out that in a few cases
>> the original reason has disappeared.  So I propose the attached patches
>> to remove the unnecessary includes.
> 
> Seems generally reasonable.  Have you checked that headerscheck and
> cpluspluscheck are happy?

Yes, I ran it through Cirrus, which includes those checks.

  5. Re: Remove unnecessary includes of system headers in header files

    Peter Eisentraut <peter@eisentraut.org> — 2023-12-04T05:42:17Z

    On 01.12.23 11:51, Shubham.Khanna@fujitsu.com wrote:
> Hi Peter,
> 
> I have reviewed the patches and also RUN the command, 'make check-world'. It is working fine. All test cases are passed successfully.

committed

> 
> Thanks and Regards,
> Shubham Khanna.
> 
> -----Original Message-----
> From: Peter Eisentraut <peter@eisentraut.org>
> Sent: Friday, December 1, 2023 1:24 PM
> To: pgsql-hackers <pgsql-hackers@postgresql.org>
> Subject: Remove unnecessary includes of system headers in header files
> 
> I noticed that some header files included system header files for no apparent reason, so I did some digging and found out that in a few cases the original reason has disappeared.  So I propose the attached patches to remove the unnecessary includes.