Horton

Re: Remove unnecessary includes of system headers in header files

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-12-02T08:39:05Z
Lists: pgsql-hackers 
On 01.12.23 17:41, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> I noticed that some header files included system header files for no
>> apparent reason, so I did some digging and found out that in a few cases
>> the original reason has disappeared.  So I propose the attached patches
>> to remove the unnecessary includes.
> 
> Seems generally reasonable.  Have you checked that headerscheck and
> cpluspluscheck are happy?

Yes, I ran it through Cirrus, which includes those checks.

Commits

  1. Remove unnecessary include of <math.h>

  2. Remove unnecessary include of <sys/socket.h>

  3. Remove unnecessary includes of <signal.h>