Horton

Thread

Commits

  1. psql: Improve tab-completion for LOCK TABLE.

  1. (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

    bt21tanigaway <bt21tanigaway@oss.nttdata.com> — 2021-09-28T07:13:45Z

    Hi,

(LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented in 
tab-complete. I made a patch for these options.

regards,
Koyu Tanigawa

  2. Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-09-28T07:36:49Z

    
On 2021/09/28 16:13, bt21tanigaway wrote:
> Hi,
> 
> (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented in tab-complete. I made a patch for these options.

Thanks for the patch!

The patch seems to forget to handle the tab-completion for
"LOCK ONLY <table-name> IN".

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  3. Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

    bt21tanigaway <bt21tanigaway@oss.nttdata.com> — 2021-09-28T08:03:57Z

    2021-09-28 16:36 に Fujii Masao さんは書きました:
> On 2021/09/28 16:13, bt21tanigaway wrote:
>> Hi,
>> 
>> (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented in 
>> tab-complete. I made a patch for these options.
> 
> Thanks for the patch!
> The patch seems to forget to handle the tab-completion for
> "LOCK ONLY <table-name> IN".

Thanks for your comment!
I attach a new patch fixed to this mail.

Regards,

Koyu Tanigawa

  4. Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

    bt21tanigaway <bt21tanigaway@oss.nttdata.com> — 2021-09-28T08:06:29Z

    2021-09-28 17:03 に bt21tanigaway さんは書きました:
> 2021-09-28 16:36 に Fujii Masao さんは書きました:
>> On 2021/09/28 16:13, bt21tanigaway wrote:
>>> Hi,
>>> 
>>> (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented in 
>>> tab-complete. I made a patch for these options.
>> 
>> Thanks for the patch!
>> The patch seems to forget to handle the tab-completion for
>> "LOCK ONLY <table-name> IN".
> 
> Thanks for your comment!
> I attach a new patch fixed to this mail.
> 
> Regards,
> 
> Koyu Tanigawa

Sorry, I forgot to attach patch file.
"fix-tab-complete2.patch" is fixed!

Regards,

Koyu Tanigawa

  5. Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

    Shinya Kato <katousnk@oss.nttdata.com> — 2021-09-28T13:46:35Z

    2021-09-28 17:06 に bt21tanigaway さんは書きました:
> 2021-09-28 17:03 に bt21tanigaway さんは書きました:
>> 2021-09-28 16:36 に Fujii Masao さんは書きました:
>>> On 2021/09/28 16:13, bt21tanigaway wrote:
>>>> Hi,
>>>> 
>>>> (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented in 
>>>> tab-complete. I made a patch for these options.
>>> 
>>> Thanks for the patch!
>>> The patch seems to forget to handle the tab-completion for
>>> "LOCK ONLY <table-name> IN".
>> 
>> Thanks for your comment!
>> I attach a new patch fixed to this mail.
>> 
>> Regards,
>> 
>> Koyu Tanigawa
> 
> Sorry, I forgot to attach patch file.
> "fix-tab-complete2.patch" is fixed!
> 
> Regards,
> 
> Koyu Tanigawa
Thank you for your patch.
I have two comments.

1. When I executed git apply, an error occured.
---
$ git apply ~/Downloads/fix-tab-complete2.patch
/home/penguin/Downloads/fix-tab-complete2.patch:14: indent with spaces.
     COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_tables, " UNION SELECT 
'TABLE'" " UNION SELECT 'ONLY'");
warning: 1 line adds whitespace errors.
---

2. The command "LOCK TABLE a, b;" can be executed, but tab-completion 
doesn't work properly. Is it OK?

-- 
Regards,

--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  6. RE: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

    shinya11.kato@nttdata.com — 2021-09-28T13:55:48Z

    >-----Original Message-----
>From: bt21tanigaway <bt21tanigaway@oss.nttdata.com>
>Sent: Tuesday, September 28, 2021 5:06 PM
>To: Fujii Masao <masao.fujii@oss.nttdata.com>;
>pgsql-hackers@lists.postgresql.org
>Subject: Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet
>implemented
>
>2021-09-28 17:03 に bt21tanigaway さんは書きました:
>> 2021-09-28 16:36 に Fujii Masao さんは書きました:
>>> On 2021/09/28 16:13, bt21tanigaway wrote:
>>>> Hi,
>>>>
>>>> (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented in
>>>> tab-complete. I made a patch for these options.
>>>
>>> Thanks for the patch!
>>> The patch seems to forget to handle the tab-completion for "LOCK ONLY
>>> <table-name> IN".
>>
>> Thanks for your comment!
>> I attach a new patch fixed to this mail.
>>
>> Regards,
>>
>> Koyu Tanigawa
>
>Sorry, I forgot to attach patch file.
>"fix-tab-complete2.patch" is fixed!
>
>Regards,
>
>Koyu Tanigawa
Thank you for your patch.
I have two comments.

1. When I executed git apply, an error occured.
---
$ git apply ~/Downloads/fix-tab-complete2.patch
/home/penguin/Downloads/fix-tab-complete2.patch:14: indent with spaces.
    COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_tables, " UNION SELECT 'TABLE'" " UNION SELECT 'ONLY'");
warning: 1 line adds whitespace errors.
---

2. The command "LOCK TABLE a, b;" can be executed, but tab-completion doesn't work properly. Is it OK?

-- 
Regards,

--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  7. Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

    bt21tanigaway <bt21tanigaway@oss.nttdata.com> — 2021-09-29T04:54:58Z

    2021-09-28 22:55 に Shinya11.Kato@nttdata.com さんは書きました:
>> -----Original Message-----
>> From: bt21tanigaway <bt21tanigaway@oss.nttdata.com>
>> Sent: Tuesday, September 28, 2021 5:06 PM
>> To: Fujii Masao <masao.fujii@oss.nttdata.com>;
>> pgsql-hackers@lists.postgresql.org
>> Subject: Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet
>> implemented
>> 
>> 2021-09-28 17:03 に bt21tanigaway さんは書きました:
>>> 2021-09-28 16:36 に Fujii Masao さんは書きました:
>>>> On 2021/09/28 16:13, bt21tanigaway wrote:
>>>>> Hi,
>>>>> 
>>>>> (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented in
>>>>> tab-complete. I made a patch for these options.
>>>> 
>>>> Thanks for the patch!
>>>> The patch seems to forget to handle the tab-completion for "LOCK 
>>>> ONLY
>>>> <table-name> IN".
>>> 
>>> Thanks for your comment!
>>> I attach a new patch fixed to this mail.
>>> 
>>> Regards,
>>> 
>>> Koyu Tanigawa
>> 
>> Sorry, I forgot to attach patch file.
>> "fix-tab-complete2.patch" is fixed!
>> 
>> Regards,
>> 
>> Koyu Tanigawa
> Thank you for your patch.
> I have two comments.
> 
> 1. When I executed git apply, an error occured.
> ---
> $ git apply ~/Downloads/fix-tab-complete2.patch
> /home/penguin/Downloads/fix-tab-complete2.patch:14: indent with spaces.
>     COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_tables, " UNION
> SELECT 'TABLE'" " UNION SELECT 'ONLY'");
> warning: 1 line adds whitespace errors.
> ---
> 
Thank you for your feedback.
I might have added whitespace when I was checking the patch file.
I attach a new patch to this mail.

> 2. The command "LOCK TABLE a, b;" can be executed, but tab-completion
> doesn't work properly. Is it OK?
It's OK for now.
But it should be able to handle a case of multiple tables in the future.

Regards,

Koyu Tanigawa

  8. RE: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

    shinya11.kato@nttdata.com — 2021-09-30T03:18:29Z

    >Thank you for your feedback.
>I might have added whitespace when I was checking the patch file.
>I attach a new patch to this mail.
Thank you for the update!

> 	else if (Matches("LOCK", MatchAny, "IN", "ACCESS|ROW") ||
>-			 Matches("LOCK", "TABLE", MatchAny, "IN", "ACCESS|ROW"))
>+			 Matches("LOCK", "TABLE", MatchAny, "IN", "ACCESS|ROW") ||
>+			 Matches("LOCK", "ONLY", MatchAny, "IN", "ACCESS|ROW") ||
>+			 Matches("LOCK", "TABLE", "ONLY", MatchAny, "IN", "ACCESS|ROW"))
I think this code is redundant, so I change following.
---
	else if (HeadMatches("LOCK") && TailMatches("IN", "ACCESS|ROW"))
---
I created the patch, and attached it. Do you think?

>> 2. The command "LOCK TABLE a, b;" can be executed, but tab-completion
>> doesn't work properly. Is it OK?
>It's OK for now.
>But it should be able to handle a case of multiple tables in the future.
OK. I agreed.

Regards,
Shinya Kato

  9. Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

    bt21tanigaway <bt21tanigaway@oss.nttdata.com> — 2021-10-04T02:17:19Z

    >> 	else if (Matches("LOCK", MatchAny, "IN", "ACCESS|ROW") ||
>> -			 Matches("LOCK", "TABLE", MatchAny, "IN", "ACCESS|ROW"))
>> +			 Matches("LOCK", "TABLE", MatchAny, "IN", "ACCESS|ROW") ||
>> +			 Matches("LOCK", "ONLY", MatchAny, "IN", "ACCESS|ROW") ||
>> +			 Matches("LOCK", "TABLE", "ONLY", MatchAny, "IN", "ACCESS|ROW"))
> I think this code is redundant, so I change following.
> ---
> 	else if (HeadMatches("LOCK") && TailMatches("IN", "ACCESS|ROW"))
> ---
> I created the patch, and attached it. Do you think?
Thank you for update!
I think that your code is more concise than mine.
There seems to be no problem.

Regards,
Koyu Tanigawa

  10. Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-10-04T04:59:19Z

    
On 2021/10/04 11:17, bt21tanigaway wrote:
>>>     else if (Matches("LOCK", MatchAny, "IN", "ACCESS|ROW") ||
>>> -             Matches("LOCK", "TABLE", MatchAny, "IN", "ACCESS|ROW"))
>>> +             Matches("LOCK", "TABLE", MatchAny, "IN", "ACCESS|ROW") ||
>>> +             Matches("LOCK", "ONLY", MatchAny, "IN", "ACCESS|ROW") ||
>>> +             Matches("LOCK", "TABLE", "ONLY", MatchAny, "IN", "ACCESS|ROW"))
>> I think this code is redundant, so I change following.
>> ---
>>     else if (HeadMatches("LOCK") && TailMatches("IN", "ACCESS|ROW"))
>> ---
>> I created the patch, and attached it. Do you think?
> Thank you for update!
> I think that your code is more concise than mine.
> There seems to be no problem.

The patch looks good to me, too. I applied cosmetic changes to it.
Attached is the updated version of the patch. Barring any objection,
I will commit it.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  11. RE: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

    shinya11.kato@nttdata.com — 2021-10-04T05:28:15Z

    >-----Original Message-----
>From: Fujii Masao <masao.fujii@oss.nttdata.com>
>Sent: Monday, October 4, 2021 1:59 PM
>To: bt21tanigaway <bt21tanigaway@oss.nttdata.com>; RDH 加藤 慎也/Kato,
>Shinya (NTT DATA) <Shinya11.Kato@jp.nttdata.com>
>Cc: pgsql-hackers@lists.postgresql.org
>Subject: Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet
>implemented
>
>
>
>On 2021/10/04 11:17, bt21tanigaway wrote:
>>>>     else if (Matches("LOCK", MatchAny, "IN", "ACCESS|ROW") ||
>>>> -             Matches("LOCK", "TABLE", MatchAny, "IN",
>>>> "ACCESS|ROW"))
>>>> +             Matches("LOCK", "TABLE", MatchAny, "IN",
>"ACCESS|ROW")
>>>> +||
>>>> +             Matches("LOCK", "ONLY", MatchAny, "IN",
>"ACCESS|ROW")
>>>> +||
>>>> +             Matches("LOCK", "TABLE", "ONLY", MatchAny, "IN",
>>>> +"ACCESS|ROW"))
>>> I think this code is redundant, so I change following.
>>> ---
>>>     else if (HeadMatches("LOCK") && TailMatches("IN", "ACCESS|ROW"))
>>> ---
>>> I created the patch, and attached it. Do you think?
>> Thank you for update!
>> I think that your code is more concise than mine.
>> There seems to be no problem.
>
>The patch looks good to me, too. I applied cosmetic changes to it.
>Attached is the updated version of the patch. Barring any objection, I will commit
>it.
Thank you for the patch!
It looks good to me.

Regards,
Shinya Kato

  12. Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-10-05T01:15:31Z

    
On 2021/10/04 14:28, Shinya11.Kato@nttdata.com wrote:
>> The patch looks good to me, too. I applied cosmetic changes to it.
>> Attached is the updated version of the patch. Barring any objection, I will commit
>> it.
> Thank you for the patch!
> It looks good to me.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION