Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented
Fujii Masao <masao.fujii@oss.nttdata.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: bt21tanigaway <bt21tanigaway@oss.nttdata.com>, Shinya11.Kato@nttdata.com
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-10-04T04:59:19Z
Lists: pgsql-hackers
Attachments
- fix_tab_completion_of_lock_fujii.patch (text/plain) patch
On 2021/10/04 11:17, bt21tanigaway wrote:
>>> else if (Matches("LOCK", MatchAny, "IN", "ACCESS|ROW") ||
>>> - Matches("LOCK", "TABLE", MatchAny, "IN", "ACCESS|ROW"))
>>> + Matches("LOCK", "TABLE", MatchAny, "IN", "ACCESS|ROW") ||
>>> + Matches("LOCK", "ONLY", MatchAny, "IN", "ACCESS|ROW") ||
>>> + Matches("LOCK", "TABLE", "ONLY", MatchAny, "IN", "ACCESS|ROW"))
>> I think this code is redundant, so I change following.
>> ---
>> else if (HeadMatches("LOCK") && TailMatches("IN", "ACCESS|ROW"))
>> ---
>> I created the patch, and attached it. Do you think?
> Thank you for update!
> I think that your code is more concise than mine.
> There seems to be no problem.
The patch looks good to me, too. I applied cosmetic changes to it.
Attached is the updated version of the patch. Barring any objection,
I will commit it.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Commits
-
psql: Improve tab-completion for LOCK TABLE.
- 0b0d277c3553 15.0 landed