Horton

Thread

Commits

  1. Reformat some node comments

  2. Update comment for IndexInfo.ii_NullsNotDistinct

  3. Update comment for IndexInfo.ii_WithoutOverlaps

  4. Fix outdated comment for IndexInfo

  1. Fix outdated comments for IndexInfo

    Japin Li <japinli@hotmail.com> — 2025-04-30T15:48:53Z

    Hi, all

While working on [1], I found outdated comments in IndexInfo.
The attached patch corrects them.

[1] https://www.postgresql.org/message-id/2A40921D-83AB-411E-ADA6-7E509A46F1E4%40logansw.com

-- 
Regrads,
Japin Li

  2. Re: Fix outdated comments for IndexInfo

    Richard Guo <guofenglinux@gmail.com> — 2025-05-01T06:45:34Z

    On Thu, May 1, 2025 at 12:49 AM Japin Li <japinli@hotmail.com> wrote:
> While working on [1], I found outdated comments in IndexInfo.
> The attached patch corrects them.

Nice catch.  LGTM.

Thanks
Richard

  3. Re: Fix outdated comments for IndexInfo

    Peter Eisentraut <peter@eisentraut.org> — 2025-05-01T10:13:43Z

    On 30.04.25 17:48, Japin Li wrote:
> While working on [1], I found outdated comments in IndexInfo.
> The attached patch corrects them.
> 
> [1] https://www.postgresql.org/message-id/2A40921D-83AB-411E-ADA6-7E509A46F1E4%40logansw.com

Maybe these per-column comments should be moved inline, similar to, for 
example, ResultRelInfo later in the file.  That would make maintaining 
them easier.

  4. Re: Fix outdated comments for IndexInfo

    Japin Li <japinli@hotmail.com> — 2025-05-01T13:47:14Z

    Hi, Peter and Richard

On Thu, 01 May 2025 at 12:13, Peter Eisentraut <peter@eisentraut.org> wrote:
> On 30.04.25 17:48, Japin Li wrote:
>> While working on [1], I found outdated comments in IndexInfo.
>> The attached patch corrects them.
>> [1]
>> https://www.postgresql.org/message-id/2A40921D-83AB-411E-ADA6-7E509A46F1E4%40logansw.com
>
> Maybe these per-column comments should be moved inline, similar to,
> for example, ResultRelInfo later in the file.  That would make
> maintaining them easier.

Thank you for the review.  The v2 patch set is attached.

v2-0001 remains unchanged; v2-0002 has been modified according to your feedback.

-- 
Regrads,
Japin Li

  5. Re: Fix outdated comments for IndexInfo

    Peter Eisentraut <peter@eisentraut.org> — 2025-07-02T07:57:50Z

    On 01.05.25 15:47, Japin Li wrote:
> On Thu, 01 May 2025 at 12:13, Peter Eisentraut <peter@eisentraut.org> wrote:
>> On 30.04.25 17:48, Japin Li wrote:
>>> While working on [1], I found outdated comments in IndexInfo.
>>> The attached patch corrects them.
>>> [1]
>>> https://www.postgresql.org/message-id/2A40921D-83AB-411E-ADA6-7E509A46F1E4%40logansw.com
>>
>> Maybe these per-column comments should be moved inline, similar to,
>> for example, ResultRelInfo later in the file.  That would make
>> maintaining them easier.
> 
> Thank you for the review.  The v2 patch set is attached.
> 
> v2-0001 remains unchanged; v2-0002 has been modified according to your feedback.

I have committed your patch 0001 and backpatched it appropriately, so 
that each branch should now have approximately correct comments.  And 
then I have applied your 0002 to master.  Thanks.

  6. Re: Fix outdated comments for IndexInfo

    Japin Li <japinli@hotmail.com> — 2025-07-03T01:44:57Z

    On Wed, 02 Jul 2025 at 09:57, Peter Eisentraut <peter@eisentraut.org> wrote:
> On 01.05.25 15:47, Japin Li wrote:
>> On Thu, 01 May 2025 at 12:13, Peter Eisentraut <peter@eisentraut.org> wrote:
>>> On 30.04.25 17:48, Japin Li wrote:
>>>> While working on [1], I found outdated comments in IndexInfo.
>>>> The attached patch corrects them.
>>>> [1]
>>>> https://www.postgresql.org/message-id/2A40921D-83AB-411E-ADA6-7E509A46F1E4%40logansw.com
>>>
>>> Maybe these per-column comments should be moved inline, similar to,
>>> for example, ResultRelInfo later in the file.  That would make
>>> maintaining them easier.
>> Thank you for the review.  The v2 patch set is attached.
>> v2-0001 remains unchanged; v2-0002 has been modified according to
>> your feedback.
>
> I have committed your patch 0001 and backpatched it appropriately, so
> that each branch should now have approximately correct comments.  And
> then I have applied your 0002 to master.  Thanks.

Thanks a lot.

-- 
Regards,
Japin Li