Horton

Re: Fix outdated comments for IndexInfo

Japin Li <japinli@hotmail.com>

View thread View on postgr.es
From: Japin Li <japinli@hotmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Richard Guo <guofenglinux@gmail.com>
Date: 2025-05-01T13:47:14Z
Lists: pgsql-hackers

Attachments

Hi, Peter and Richard

On Thu, 01 May 2025 at 12:13, Peter Eisentraut <peter@eisentraut.org> wrote:
> On 30.04.25 17:48, Japin Li wrote:
>> While working on [1], I found outdated comments in IndexInfo.
>> The attached patch corrects them.
>> [1]
>> https://www.postgresql.org/message-id/2A40921D-83AB-411E-ADA6-7E509A46F1E4%40logansw.com
>
> Maybe these per-column comments should be moved inline, similar to,
> for example, ResultRelInfo later in the file.  That would make
> maintaining them easier.

Thank you for the review.  The v2 patch set is attached.

v2-0001 remains unchanged; v2-0002 has been modified according to your feedback.

-- 
Regrads,
Japin Li

Commits

  1. Reformat some node comments

  2. Update comment for IndexInfo.ii_NullsNotDistinct

  3. Update comment for IndexInfo.ii_WithoutOverlaps

  4. Fix outdated comment for IndexInfo