Horton

Thread

Commits

  1. Remove duplicated assignment of LLVMJitHandle->lljit

  1. Duplicated LLVMJitHandle->lljit assignment?

    Matheus Alcantara <mths.dev@pm.me> — 2023-07-13T00:22:13Z

    Hi,

I was reading the jit implementation and I notice that the lljit field of
LLVMJitHandle is being assigned twice on llvm_compile_module function, is this
correct? I'm attaching a supposed fixes that removes  the second assignment. I
ran meson test and all tests have pass.

--
Matheus Alcantara

  2. Re: Duplicated LLVMJitHandle->lljit assignment?

    Gurjeet Singh <gurjeet@singh.im> — 2023-07-13T01:41:37Z

    On Wed, Jul 12, 2023 at 5:22 PM Matheus Alcantara <mths.dev@pm.me> wrote:
>
> I was reading the jit implementation and I notice that the lljit field of
> LLVMJitHandle is being assigned twice on llvm_compile_module function, is this
> correct? I'm attaching a supposed fixes that removes  the second assignment. I
> ran meson test and all tests have pass.

-        handle->lljit = compile_orc;

LGTM.

Best regards,
Gurjeet
http://Gurje.et

  3. Re: Duplicated LLVMJitHandle->lljit assignment?

    Michael Paquier <michael@paquier.xyz> — 2023-07-13T03:39:02Z

    On Wed, Jul 12, 2023 at 06:41:37PM -0700, Gurjeet Singh wrote:
> LGTM.

Indeed.  It looks like a small thinko from 6c57f2e when support for
LLVM12 was added.
--
Michael