Horton

Re: Duplicated LLVMJitHandle->lljit assignment?

Gurjeet Singh <gurjeet@singh.im>

View thread View on postgr.es
From: Gurjeet Singh <gurjeet@singh.im>
To: Matheus Alcantara <mths.dev@pm.me>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-07-13T01:41:37Z
Lists: pgsql-hackers 
On Wed, Jul 12, 2023 at 5:22 PM Matheus Alcantara <mths.dev@pm.me> wrote:
>
> I was reading the jit implementation and I notice that the lljit field of
> LLVMJitHandle is being assigned twice on llvm_compile_module function, is this
> correct? I'm attaching a supposed fixes that removes  the second assignment. I
> ran meson test and all tests have pass.

-        handle->lljit = compile_orc;

LGTM.

Best regards,
Gurjeet
http://Gurje.et

Commits

  1. Remove duplicated assignment of LLVMJitHandle->lljit