Horton

Thread

Commits

  1. Update more obsolete multixact.c comments.

  2. Update obsolete multixact.c comments.

  1. Update comments in multixact.c

    Yu Shi (Fujitsu) <shiy.fnst@fujitsu.com> — 2023-01-17T09:33:18Z

    Hi,

I noticed that commit 5212d447fa updated some comments in multixact.c because
SLRU truncation for multixacts is performed during VACUUM, instead of
checkpoint. Should the following comments which mentioned checkpointer be
changed, too?

1.
* we compute it (using nextMXact if none are valid).  Each backend is
* required not to attempt to access any SLRU data for MultiXactIds older
* than its own OldestVisibleMXactId[] setting; this is necessary because
* the checkpointer could truncate away such data at any instant.

2.
 * We set the OldestVisibleMXactId for a given transaction the first time
 * it's going to inspect any MultiXactId.  Once we have set this, we are
 * guaranteed that the checkpointer won't truncate off SLRU data for
 * MultiXactIds at or after our OldestVisibleMXactId.

Regards,
Shi yu

  2. Re: Update comments in multixact.c

    Peter Geoghegan <pg@bowt.ie> — 2023-01-17T22:03:54Z

    On Tue, Jan 17, 2023 at 1:33 AM shiy.fnst@fujitsu.com
<shiy.fnst@fujitsu.com> wrote:
> I noticed that commit 5212d447fa updated some comments in multixact.c because
> SLRU truncation for multixacts is performed during VACUUM, instead of
> checkpoint. Should the following comments which mentioned checkpointer be
> changed, too?

Yes, I think so.

-- 
Peter Geoghegan

  3. RE: Update comments in multixact.c

    Yu Shi (Fujitsu) <shiy.fnst@fujitsu.com> — 2023-01-18T10:02:28Z

    On Wed, Jan 18, 2023 6:04 AM Peter Geoghegan <pg@bowt.ie> wrote:
> 
> On Tue, Jan 17, 2023 at 1:33 AM shiy.fnst@fujitsu.com
> <shiy.fnst@fujitsu.com> wrote:
> > I noticed that commit 5212d447fa updated some comments in multixact.c
> because
> > SLRU truncation for multixacts is performed during VACUUM, instead of
> > checkpoint. Should the following comments which mentioned checkpointer be
> > changed, too?
> 
> Yes, I think so.

Thanks for your reply.

Attach a patch which fixed them.

Regards,
Shi yu

  4. Re: Update comments in multixact.c

    Peter Geoghegan <pg@bowt.ie> — 2023-01-24T23:18:10Z

    On Wed, Jan 18, 2023 at 2:02 AM shiy.fnst@fujitsu.com
<shiy.fnst@fujitsu.com> wrote:
> Thanks for your reply.
>
> Attach a patch which fixed them.

Pushed something close to that just now. I decided that it was better
to not specify when truncation happened in these two places at all,
though. The important detail is that it can happen if certain rules
are not followed.

Thanks
-- 
Peter Geoghegan