Horton

Thread

Commits

  1. Add missing check of noError parameter in euc_tw_and_big5.c

  2. Add 'noError' argument to encoding conversion functions.

  1. add 'noError' to euc_tw_and_big5.c

    wangyukun@fujitsu.com <wangyukun@fujitsu.com> — 2021-07-21T02:15:14Z

    Hi, Heikki

'noError' argument was added at commit ea1b99a661,
but it seems to be neglected in euc_tw_and_big5.c Line 289.
please see the attachment.

Regards,
Yukun Wang

  2. Re: add 'noError' to euc_tw_and_big5.c

    Michael Paquier <michael@paquier.xyz> — 2021-07-21T02:35:33Z

    On Wed, Jul 21, 2021 at 02:15:14AM +0000, wangyukun@fujitsu.com wrote:
> 'noError' argument was added at commit ea1b99a661,
> but it seems to be neglected in euc_tw_and_big5.c Line 289.
> please see the attachment.

That sounds right to me.  Double-checking the area, I am not seeing
another portion of the code to fix.
--
Michael

  3. Re: add 'noError' to euc_tw_and_big5.c

    John Naylor <john.naylor@enterprisedb.com> — 2021-07-21T11:44:06Z

    On Tue, Jul 20, 2021 at 10:35 PM Michael Paquier <michael@paquier.xyz>
wrote:
>
> On Wed, Jul 21, 2021 at 02:15:14AM +0000, wangyukun@fujitsu.com wrote:
> > 'noError' argument was added at commit ea1b99a661,
> > but it seems to be neglected in euc_tw_and_big5.c Line 289.
> > please see the attachment.
>
> That sounds right to me.  Double-checking the area, I am not seeing
> another portion of the code to fix.

Agreed, will push.

--
John Naylor
EDB: http://www.enterprisedb.com

  4. Re: add 'noError' to euc_tw_and_big5.c

    John Naylor <john.naylor@enterprisedb.com> — 2021-07-21T13:47:31Z

    On Tue, Jul 20, 2021 at 10:35 PM Michael Paquier <michael@paquier.xyz>
wrote:
>
> On Wed, Jul 21, 2021 at 02:15:14AM +0000, wangyukun@fujitsu.com wrote:
> > 'noError' argument was added at commit ea1b99a661,
> > but it seems to be neglected in euc_tw_and_big5.c Line 289.
> > please see the attachment.
>
> That sounds right to me.  Double-checking the area, I am not seeing
> another portion of the code to fix.

Pushed, but I forgot to give you review credit, sorry about that. Thanks
for taking a look!

--
John Naylor
EDB: http://www.enterprisedb.com