Horton

Re: add 'noError' to euc_tw_and_big5.c

John Naylor <john.naylor@enterprisedb.com>

View thread View on postgr.es
From: John Naylor <john.naylor@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "wangyukun@fujitsu.com" <wangyukun@fujitsu.com>, Heikki Linnakangas <hlinnaka@iki.fi>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2021-07-21T13:47:31Z
Lists: pgsql-hackers 
On Tue, Jul 20, 2021 at 10:35 PM Michael Paquier <michael@paquier.xyz>
wrote:
>
> On Wed, Jul 21, 2021 at 02:15:14AM +0000, wangyukun@fujitsu.com wrote:
> > 'noError' argument was added at commit ea1b99a661,
> > but it seems to be neglected in euc_tw_and_big5.c Line 289.
> > please see the attachment.
>
> That sounds right to me.  Double-checking the area, I am not seeing
> another portion of the code to fix.

Pushed, but I forgot to give you review credit, sorry about that. Thanks
for taking a look!

--
John Naylor
EDB: http://www.enterprisedb.com

Commits

  1. Add missing check of noError parameter in euc_tw_and_big5.c

  2. Add 'noError' argument to encoding conversion functions.