Horton

Thread

Commits

  1. Improve errors related to incorrect TLI on checkpoint record replay

  1. Correct error message for end-of-recovery record TLI

    Amul Sul <sulamul@gmail.com> — 2021-10-28T12:58:41Z

    Hi,

In xlog_redo, for end-of-recovery case error message describes the
record as a checkpoint record which seems to be incorrect; the
attached patch corrects that.

--
Regards,
Amul Sul
EDB: http://www.enterprisedb.com

  2. Re: Correct error message for end-of-recovery record TLI

    Robert Haas <robertmhaas@gmail.com> — 2021-10-28T19:21:49Z

    On Thu, Oct 28, 2021 at 8:59 AM Amul Sul <sulamul@gmail.com> wrote:
> In xlog_redo, for end-of-recovery case error message describes the
> record as a checkpoint record which seems to be incorrect; the
> attached patch corrects that.

The analysis and patch appear correct to me.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

  3. Re: Correct error message for end-of-recovery record TLI

    Nathan Bossart <bossartn@amazon.com> — 2021-10-28T19:52:51Z

    On 10/28/21, 12:23 PM, "Robert Haas" <robertmhaas@gmail.com> wrote:
> On Thu, Oct 28, 2021 at 8:59 AM Amul Sul <sulamul@gmail.com> wrote:
>> In xlog_redo, for end-of-recovery case error message describes the
>> record as a checkpoint record which seems to be incorrect; the
>> attached patch corrects that.
>
> The analysis and patch appear correct to me.

When I apply the patch, it changes the PANIC message in the
XLOG_CHECKPOINT_ONLINE section, not the XLOG_END_OF_RECOVERY one.

Nathan

  4. Re: Correct error message for end-of-recovery record TLI

    Nathan Bossart <bossartn@amazon.com> — 2021-10-28T19:54:00Z

    On 10/28/21, 12:52 PM, "Bossart, Nathan" <bossartn@amazon.com> wrote:
> On 10/28/21, 12:23 PM, "Robert Haas" <robertmhaas@gmail.com> wrote:
>> On Thu, Oct 28, 2021 at 8:59 AM Amul Sul <sulamul@gmail.com> wrote:
>>> In xlog_redo, for end-of-recovery case error message describes the
>>> record as a checkpoint record which seems to be incorrect; the
>>> attached patch corrects that.
>>
>> The analysis and patch appear correct to me.
>
> When I apply the patch, it changes the PANIC message in the
> XLOG_CHECKPOINT_ONLINE section, not the XLOG_END_OF_RECOVERY one.

But other than that, the change seems reasonable to me.

Nathan

  5. Re: Correct error message for end-of-recovery record TLI

    Robert Haas <robertmhaas@gmail.com> — 2021-10-28T21:05:50Z

    On Thu, Oct 28, 2021 at 3:52 PM Bossart, Nathan <bossartn@amazon.com> wrote:
> When I apply the patch, it changes the PANIC message in the
> XLOG_CHECKPOINT_ONLINE section, not the XLOG_END_OF_RECOVERY one.

Well that's a good point. *facepalm*

-- 
Robert Haas
EDB: http://www.enterprisedb.com

  6. Re: Correct error message for end-of-recovery record TLI

    Amul Sul <sulamul@gmail.com> — 2021-10-29T04:13:36Z

    On Fri, Oct 29, 2021 at 2:36 AM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Thu, Oct 28, 2021 at 3:52 PM Bossart, Nathan <bossartn@amazon.com> wrote:
> > When I apply the patch, it changes the PANIC message in the
> > XLOG_CHECKPOINT_ONLINE section, not the XLOG_END_OF_RECOVERY one.
>
> Well that's a good point. *facepalm*
>

Oops... :|

Corrected in the attached version.

Regards,
Amul

  7. Re: Correct error message for end-of-recovery record TLI

    Nathan Bossart <bossartn@amazon.com> — 2021-12-01T19:09:34Z

    On 10/28/21, 9:15 PM, "Amul Sul" <sulamul@gmail.com> wrote:
> On Fri, Oct 29, 2021 at 2:36 AM Robert Haas <robertmhaas@gmail.com> wrote:
>>
>> On Thu, Oct 28, 2021 at 3:52 PM Bossart, Nathan <bossartn@amazon.com> wrote:
>> > When I apply the patch, it changes the PANIC message in the
>> > XLOG_CHECKPOINT_ONLINE section, not the XLOG_END_OF_RECOVERY one.
>>
>> Well that's a good point. *facepalm*
>>
>
> Oops... :|
> 
> Corrected in the attached version.

The patch no longer applied, so I went ahead and rebased it.

Nathan

  8. Re: Correct error message for end-of-recovery record TLI

    Michael Paquier <michael@paquier.xyz> — 2022-01-25T04:38:38Z

    On Wed, Dec 01, 2021 at 07:09:34PM +0000, Bossart, Nathan wrote:
> The patch no longer applied, so I went ahead and rebased it.

This was on the CF stack for some time, so applied.  I have also
changed the messages produced for the shutdown and online checkpoint
records as they used the same messages so as one can get more
context depending on the record types.
--
Michael

  9. Re: Correct error message for end-of-recovery record TLI

    Amul Sul <sulamul@gmail.com> — 2022-01-25T04:40:46Z

    On Tue, Jan 25, 2022 at 10:08 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Dec 01, 2021 at 07:09:34PM +0000, Bossart, Nathan wrote:
> > The patch no longer applied, so I went ahead and rebased it.
>
> This was on the CF stack for some time, so applied.  I have also
> changed the messages produced for the shutdown and online checkpoint
> records as they used the same messages so as one can get more
> context depending on the record types.

A ton of thanks for the improvement & the commit.

Regards,
Amul

  10. Re: Correct error message for end-of-recovery record TLI

    Nathan Bossart <bossartn@amazon.com> — 2022-01-25T17:50:48Z

    On 1/24/22, 8:42 PM, "Amul Sul" <sulamul@gmail.com> wrote:
> On Tue, Jan 25, 2022 at 10:08 AM Michael Paquier <michael@paquier.xyz> wrote:
>>
>> On Wed, Dec 01, 2021 at 07:09:34PM +0000, Bossart, Nathan wrote:
>> > The patch no longer applied, so I went ahead and rebased it.
>>
>> This was on the CF stack for some time, so applied.  I have also
>> changed the messages produced for the shutdown and online checkpoint
>> records as they used the same messages so as one can get more
>> context depending on the record types.
>
> A ton of thanks for the improvement & the commit.

+1, thanks!

Nathan