Horton

Re: Correct error message for end-of-recovery record TLI

Nathan Bossart <bossartn@amazon.com>

View thread View on postgr.es
From: "Bossart, Nathan" <bossartn@amazon.com>
To: Robert Haas <robertmhaas@gmail.com>, Amul Sul <sulamul@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-28T19:52:51Z
Lists: pgsql-hackers 
On 10/28/21, 12:23 PM, "Robert Haas" <robertmhaas@gmail.com> wrote:
> On Thu, Oct 28, 2021 at 8:59 AM Amul Sul <sulamul@gmail.com> wrote:
>> In xlog_redo, for end-of-recovery case error message describes the
>> record as a checkpoint record which seems to be incorrect; the
>> attached patch corrects that.
>
> The analysis and patch appear correct to me.

When I apply the patch, it changes the PANIC message in the
XLOG_CHECKPOINT_ONLINE section, not the XLOG_END_OF_RECOVERY one.

Nathan

Commits

  1. Improve errors related to incorrect TLI on checkpoint record replay