Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. passwordcheck: Add test suite

  1. pgsql: passwordcheck: Add test suite

    Peter Eisentraut <peter_e@gmx.net> — 2017-09-15T02:46:06Z

    passwordcheck: Add test suite
    
    Also improve one error message.
    
    Reviewed-by: David Steele <david@pgmasters.net>
    
    Branch
    ------
    master
    
    Details
    -------
    https://git.postgresql.org/pg/commitdiff/af7211e92dc2bba66f90de9e5bea6ae5fa914c61
    
    Modified Files
    --------------
    contrib/passwordcheck/.gitignore                 |  4 ++++
    contrib/passwordcheck/Makefile                   |  5 +++++
    contrib/passwordcheck/expected/passwordcheck.out | 18 ++++++++++++++++++
    contrib/passwordcheck/passwordcheck.c            |  2 +-
    contrib/passwordcheck/passwordcheck.conf         |  1 +
    contrib/passwordcheck/sql/passwordcheck.sql      | 21 +++++++++++++++++++++
    6 files changed, 50 insertions(+), 1 deletion(-)
    
    
    
  2. Re: [COMMITTERS] pgsql: passwordcheck: Add test suite

    Michael Paquier <michael.paquier@gmail.com> — 2017-09-15T03:02:13Z

    On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
    > passwordcheck: Add test suite
    >
    > Also improve one error message.
    >
    > Reviewed-by: David Steele <david@pgmasters.net>
    
    Sorry for showing up late for this topic.
    +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf
    +REGRESS = passwordcheck
    +# disabled because these tests require setting shared_preload_libraries
    +NO_INSTALLCHECK = 1
    You could have avoided all that by just issuing "load
    'passwordcheck';" at the beginning of the test. And you gain support
    for installcheck this way.
    -- 
    Michael
    
    
    
  3. Re: [COMMITTERS] pgsql: passwordcheck: Add test suite

    Michael Paquier <michael.paquier@gmail.com> — 2017-09-15T04:20:07Z

    On Fri, Sep 15, 2017 at 12:02 PM, Michael Paquier
    <michael.paquier@gmail.com> wrote:
    > On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
    >> passwordcheck: Add test suite
    >>
    >> Also improve one error message.
    >>
    >> Reviewed-by: David Steele <david@pgmasters.net>
    >
    > Sorry for showing up late for this topic.
    > +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf
    > +REGRESS = passwordcheck
    > +# disabled because these tests require setting shared_preload_libraries
    > +NO_INSTALLCHECK = 1
    > You could have avoided all that by just issuing "load
    > 'passwordcheck';" at the beginning of the test. And you gain support
    > for installcheck this way.
    
    In short you just need the attached ;)
    -- 
    Michael
    
  4. Re: [COMMITTERS] pgsql: passwordcheck: Add test suite

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2017-11-02T16:57:52Z

    On 9/15/17 00:20, Michael Paquier wrote:
    > On Fri, Sep 15, 2017 at 12:02 PM, Michael Paquier
    > <michael.paquier@gmail.com> wrote:
    >> On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
    >>> passwordcheck: Add test suite
    >>>
    >>> Also improve one error message.
    >>>
    >>> Reviewed-by: David Steele <david@pgmasters.net>
    >>
    >> Sorry for showing up late for this topic.
    >> +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf
    >> +REGRESS = passwordcheck
    >> +# disabled because these tests require setting shared_preload_libraries
    >> +NO_INSTALLCHECK = 1
    >> You could have avoided all that by just issuing "load
    >> 'passwordcheck';" at the beginning of the test. And you gain support
    >> for installcheck this way.
    > 
    > In short you just need the attached ;)
    
    committed
    
    -- 
    Peter Eisentraut              http://www.2ndQuadrant.com/
    PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services