Re: [COMMITTERS] pgsql: passwordcheck: Add test suite

Michael Paquier <michael.paquier@gmail.com>

From: Michael Paquier <michael.paquier@gmail.com>

To: Peter Eisentraut <peter_e@gmx.net>

Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>

Date: 2017-09-15T04:20:07Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

passwordcheck: Add test suite
- af7211e92dc2 11.0 cited

Attachments

0001-Simplify-new-test-suite-handling-of-passwordcheck.patch (application/octet-stream) patch 0001

On Fri, Sep 15, 2017 at 12:02 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
>> passwordcheck: Add test suite
>>
>> Also improve one error message.
>>
>> Reviewed-by: David Steele <david@pgmasters.net>
>
> Sorry for showing up late for this topic.
> +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf
> +REGRESS = passwordcheck
> +# disabled because these tests require setting shared_preload_libraries
> +NO_INSTALLCHECK = 1
> You could have avoided all that by just issuing "load
> 'passwordcheck';" at the beginning of the test. And you gain support
> for installcheck this way.

In short you just need the attached ;)
-- 
Michael