Horton

Thread

Commits

  1. Simplify the example of VACUUM in documentation.

  2. Allow vacuums to report oldestxmin

  3. Message editing: remove gratuitous variations in message wording, standardize

  1. pgsql: Allow vacuums to report oldestxmin

    Simon Riggs <simon@2ndquadrant.com> — 2017-03-03T13:50:11Z

    Allow vacuums to report oldestxmin

Allow VACUUM and Autovacuum to report the oldestxmin value they
used while cleaning tables, helping to make better sense out of
the other statistics we report in various cases.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c

Modified Files
--------------
src/backend/commands/vacuumlazy.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

  2. Re: pgsql: Allow vacuums to report oldestxmin

    Masahiko Sawada <sawada.mshk@gmail.com> — 2017-03-06T12:37:58Z

    On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
> Allow vacuums to report oldestxmin
>
> Allow VACUUM and Autovacuum to report the oldestxmin value they
> used while cleaning tables, helping to make better sense out of
> the other statistics we report in various cases.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>
> Modified Files
> --------------
> src/backend/commands/vacuumlazy.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>

Should we change the example in vacuum.sgml file as well? Attached patch.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  3. Re: pgsql: Allow vacuums to report oldestxmin

    Fujii Masao <masao.fujii@gmail.com> — 2017-03-25T16:37:21Z

    On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
>> Allow vacuums to report oldestxmin
>>
>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>> used while cleaning tables, helping to make better sense out of
>> the other statistics we report in various cases.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>
>> Modified Files
>> --------------
>> src/backend/commands/vacuumlazy.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>>
>
> Should we change the example in vacuum.sgml file as well? Attached patch.

"tuples" in the above should be "row versions"?
We should review not only this line but also all the lines in the example
of VERBOSE output, I think.

Regards,

-- 
Fujii Masao

  4. Re: pgsql: Allow vacuums to report oldestxmin

    Masahiko Sawada <sawada.mshk@gmail.com> — 2017-03-25T17:26:20Z

    On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
>>> Allow vacuums to report oldestxmin
>>>
>>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>>> used while cleaning tables, helping to make better sense out of
>>> the other statistics we report in various cases.
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>>
>>> Modified Files
>>> --------------
>>> src/backend/commands/vacuumlazy.c | 9 +++++----
>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>
>>>
>>
>> Should we change the example in vacuum.sgml file as well? Attached patch.
>
> "tuples" in the above should be "row versions"?
> We should review not only this line but also all the lines in the example
> of VERBOSE output, I think.

Right. These verbose log messages are out of date. I ran
VACUUM(VERBOSE, ANALYZE) with same scenario as current example as
possible. Attached patch updates verbose log messages.


Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  5. Re: pgsql: Allow vacuums to report oldestxmin

    Masahiko Sawada <sawada.mshk@gmail.com> — 2017-03-27T16:06:57Z

    On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
>>>> Allow vacuums to report oldestxmin
>>>>
>>>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>>>> used while cleaning tables, helping to make better sense out of
>>>> the other statistics we report in various cases.
>>>>
>>>> Branch
>>>> ------
>>>> master
>>>>
>>>> Details
>>>> -------
>>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>>>
>>>> Modified Files
>>>> --------------
>>>> src/backend/commands/vacuumlazy.c | 9 +++++----
>>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>>
>>>>
>>>
>>> Should we change the example in vacuum.sgml file as well? Attached patch.
>>
>> "tuples" in the above should be "row versions"?
>> We should review not only this line but also all the lines in the example
>> of VERBOSE output, I think.
>
> Right. These verbose log messages are out of date. I ran
> VACUUM(VERBOSE, ANALYZE) with same scenario as current example as
> possible. Attached patch updates verbose log messages.
>
>

Surprisingly the changes "tuples" -> "row versions" in vacuumlazy.c is
introduced by commit feb4f44d296b88b7f0723f4a4f3945a371276e0b in 2003.
If this patch is applied, it should back-patch to all supported
branches.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  6. Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

    Fujii Masao <masao.fujii@gmail.com> — 2017-03-28T16:32:16Z

    On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
>>>>> Allow vacuums to report oldestxmin
>>>>>
>>>>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>>>>> used while cleaning tables, helping to make better sense out of
>>>>> the other statistics we report in various cases.
>>>>>
>>>>> Branch
>>>>> ------
>>>>> master
>>>>>
>>>>> Details
>>>>> -------
>>>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>>>>
>>>>> Modified Files
>>>>> --------------
>>>>> src/backend/commands/vacuumlazy.c | 9 +++++----
>>>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>>>
>>>>>
>>>>
>>>> Should we change the example in vacuum.sgml file as well? Attached patch.
>>>
>>> "tuples" in the above should be "row versions"?
>>> We should review not only this line but also all the lines in the example
>>> of VERBOSE output, I think.
>>
>> Right. These verbose log messages are out of date. I ran
>> VACUUM(VERBOSE, ANALYZE) with same scenario as current example as
>> possible. Attached patch updates verbose log messages.
>>
>>
>
> Surprisingly the changes "tuples" -> "row versions" in vacuumlazy.c is
> introduced by commit feb4f44d296b88b7f0723f4a4f3945a371276e0b in 2003.

This is the evidence that no one cares about the details of VACUUM VERBOSE
output example. So I'm tempted to simplify the example (please see the
attached patch) instead of keeping updating the example.

> If this patch is applied, it should back-patch to all supported
> branches.

Not sure if it's worth back-patching that.

Regards,

-- 
Fujii Masao

  7. Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

    Fujii Masao <masao.fujii@gmail.com> — 2017-03-28T16:33:55Z

    On Wed, Mar 29, 2017 at 1:32 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>>>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
>>>>>> Allow vacuums to report oldestxmin
>>>>>>
>>>>>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>>>>>> used while cleaning tables, helping to make better sense out of
>>>>>> the other statistics we report in various cases.
>>>>>>
>>>>>> Branch
>>>>>> ------
>>>>>> master
>>>>>>
>>>>>> Details
>>>>>> -------
>>>>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>>>>>
>>>>>> Modified Files
>>>>>> --------------
>>>>>> src/backend/commands/vacuumlazy.c | 9 +++++----
>>>>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>>>>
>>>>>>
>>>>>
>>>>> Should we change the example in vacuum.sgml file as well? Attached patch.
>>>>
>>>> "tuples" in the above should be "row versions"?
>>>> We should review not only this line but also all the lines in the example
>>>> of VERBOSE output, I think.
>>>
>>> Right. These verbose log messages are out of date. I ran
>>> VACUUM(VERBOSE, ANALYZE) with same scenario as current example as
>>> possible. Attached patch updates verbose log messages.
>>>
>>>
>>
>> Surprisingly the changes "tuples" -> "row versions" in vacuumlazy.c is
>> introduced by commit feb4f44d296b88b7f0723f4a4f3945a371276e0b in 2003.
>
> This is the evidence that no one cares about the details of VACUUM VERBOSE
> output example. So I'm tempted to simplify the example (please see the
> attached patch) instead of keeping updating the example.

Patch attached.

Regards,

-- 
Fujii Masao

  8. Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2017-03-28T17:26:08Z

    Fujii Masao wrote:

> This is the evidence that no one cares about the details of VACUUM VERBOSE
> output example. So I'm tempted to simplify the example (please see the
> attached patch) instead of keeping updating the example.

Agreed.

> > If this patch is applied, it should back-patch to all supported
> > branches.
> 
> Not sure if it's worth back-patching that.

I see no reason to keep it in back branches either.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  9. Re: pgsql: Allow vacuums to report oldestxmin

    Masahiko Sawada <sawada.mshk@gmail.com> — 2017-03-29T06:31:32Z

    On Wed, Mar 29, 2017 at 1:32 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>>>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
>>>>>> Allow vacuums to report oldestxmin
>>>>>>
>>>>>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>>>>>> used while cleaning tables, helping to make better sense out of
>>>>>> the other statistics we report in various cases.
>>>>>>
>>>>>> Branch
>>>>>> ------
>>>>>> master
>>>>>>
>>>>>> Details
>>>>>> -------
>>>>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>>>>>
>>>>>> Modified Files
>>>>>> --------------
>>>>>> src/backend/commands/vacuumlazy.c | 9 +++++----
>>>>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>>>>
>>>>>>
>>>>>
>>>>> Should we change the example in vacuum.sgml file as well? Attached patch.
>>>>
>>>> "tuples" in the above should be "row versions"?
>>>> We should review not only this line but also all the lines in the example
>>>> of VERBOSE output, I think.
>>>
>>> Right. These verbose log messages are out of date. I ran
>>> VACUUM(VERBOSE, ANALYZE) with same scenario as current example as
>>> possible. Attached patch updates verbose log messages.
>>>
>>>
>>
>> Surprisingly the changes "tuples" -> "row versions" in vacuumlazy.c is
>> introduced by commit feb4f44d296b88b7f0723f4a4f3945a371276e0b in 2003.
>
> This is the evidence that no one cares about the details of VACUUM VERBOSE
> output example. So I'm tempted to simplify the example (please see the
> attached patch) instead of keeping updating the example.

Yes. I agree.

>
>> If this patch is applied, it should back-patch to all supported
>> branches.
>
> Not sure if it's worth back-patching that.
>
> Regards,
>
> --
> Fujii Masao

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  10. Re: pgsql: Allow vacuums to report oldestxmin

    Fujii Masao <masao.fujii@gmail.com> — 2017-03-30T16:45:04Z

    On Wed, Mar 29, 2017 at 3:31 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> On Wed, Mar 29, 2017 at 1:32 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>> On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>>> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>>>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>>>>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
>>>>>>> Allow vacuums to report oldestxmin
>>>>>>>
>>>>>>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>>>>>>> used while cleaning tables, helping to make better sense out of
>>>>>>> the other statistics we report in various cases.
>>>>>>>
>>>>>>> Branch
>>>>>>> ------
>>>>>>> master
>>>>>>>
>>>>>>> Details
>>>>>>> -------
>>>>>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>>>>>>
>>>>>>> Modified Files
>>>>>>> --------------
>>>>>>> src/backend/commands/vacuumlazy.c | 9 +++++----
>>>>>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> Should we change the example in vacuum.sgml file as well? Attached patch.
>>>>>
>>>>> "tuples" in the above should be "row versions"?
>>>>> We should review not only this line but also all the lines in the example
>>>>> of VERBOSE output, I think.
>>>>
>>>> Right. These verbose log messages are out of date. I ran
>>>> VACUUM(VERBOSE, ANALYZE) with same scenario as current example as
>>>> possible. Attached patch updates verbose log messages.
>>>>
>>>>
>>>
>>> Surprisingly the changes "tuples" -> "row versions" in vacuumlazy.c is
>>> introduced by commit feb4f44d296b88b7f0723f4a4f3945a371276e0b in 2003.
>>
>> This is the evidence that no one cares about the details of VACUUM VERBOSE
>> output example. So I'm tempted to simplify the example (please see the
>> attached patch) instead of keeping updating the example.
>
> Yes. I agree.

Pushed. I back-patched to all supported versions according to
Alvaro's comment upthread.

Regards,

-- 
Fujii Masao