Re: pgsql: Allow vacuums to report oldestxmin
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>, pgsql-committers <pgsql-committers@postgresql.org>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-03-25T17:26:20Z
Lists: pgsql-hackers
Attachments
- fix_vacuum_example_in_doc_v2.patch (application/octet-stream) patch v2
On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao <masao.fujii@gmail.com> wrote: > On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote: >> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs <simon@2ndquadrant.com> wrote: >>> Allow vacuums to report oldestxmin >>> >>> Allow VACUUM and Autovacuum to report the oldestxmin value they >>> used while cleaning tables, helping to make better sense out of >>> the other statistics we report in various cases. >>> >>> Branch >>> ------ >>> master >>> >>> Details >>> ------- >>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c >>> >>> Modified Files >>> -------------- >>> src/backend/commands/vacuumlazy.c | 9 +++++---- >>> 1 file changed, 5 insertions(+), 4 deletions(-) >>> >>> >> >> Should we change the example in vacuum.sgml file as well? Attached patch. > > "tuples" in the above should be "row versions"? > We should review not only this line but also all the lines in the example > of VERBOSE output, I think. Right. These verbose log messages are out of date. I ran VACUUM(VERBOSE, ANALYZE) with same scenario as current example as possible. Attached patch updates verbose log messages. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
Commits
-
Simplify the example of VACUUM in documentation.
- 75eea8d7f54b 9.2.21 landed
- 82f7c3255300 9.3.17 landed
- cb366b507995 9.4.12 landed
- 86f0e538955e 9.5.7 landed
- fa0d1fd8955c 9.6.3 landed
- ec19693014ed 10.0 landed
-
Allow vacuums to report oldestxmin
- 9eb344faf54a 10.0 cited
-
Message editing: remove gratuitous variations in message wording, standardize
- feb4f44d296b 7.4.1 cited