Re: Fix out-of-date comment on makeRangeConstructors
Chao Li <li.evan.chao@gmail.com>
From: Chao Li <li.evan.chao@gmail.com>
To: Paul A Jungwirth <pj@illuminatedcomputing.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-12-05T02:26:19Z
Lists: pgsql-hackers
> On Dec 5, 2025, at 06:34, Paul A Jungwirth <pj@illuminatedcomputing.com> wrote:
>
> Hi Hackers,
>
> I noticed that makeRangeConstructors (in commands/typecmds.c) says:
>
>> We actually define 4 functions, with 0 through 3 arguments.
>
> But that hasn't been true since 2011 (df73584431). We only have 2-arg
> and 3-arg functions. Here is a quick patch to update the comment.
>
> Yours,
>
> --
> Paul ~{:-)
> pj@illuminatedcomputing.com
> <v1-0001-Fix-out-of-date-comment-on-makeRangeConstructors.patch>
I think the fix is reasonable, which reflects to the current code:
```
static const char *const prosrc[2] = {"range_constructor2",
"range_constructor3"};
static const int pronargs[2] = {2, 3};
```
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix out-of-date comment on makeRangeConstructors
- abb331da0a34 19 (unreleased) landed