Thread

1. pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr()

   Tom Lane <tgl@postgresql.org> — 2010-06-03T22:17:32Z

   Log Message:
   -----------
   Add current WAL end (as seen by walsender, ie, GetWriteRecPtr() result)
   and current server clock time to SR data messages.  These are not currently
   used on the slave side but seem likely to be useful in future, and it'd be
   better not to change the SR protocol after release.  Per discussion.
   Also do some minor code review and cleanup on walsender.c, and improve the
   protocol documentation.
   
   Modified Files:
   --------------
       pgsql/doc/src/sgml:
           protocol.sgml (r1.87 -> r1.88)
           (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/protocol.sgml?r1=1.87&r2=1.88)
       pgsql/src/backend/replication:
           walreceiver.c (r1.10 -> r1.11)
           (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/replication/walreceiver.c?r1=1.10&r2=1.11)
           walsender.c (r1.24 -> r1.25)
           (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/replication/walsender.c?r1=1.24&r2=1.25)
       pgsql/src/include/replication:
           walreceiver.h (r1.8 -> r1.9)
           (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.8&r2=1.9)
   
   Added Files:
   -----------
       pgsql/src/include/replication:
           walprotocol.h (r1.1)
           (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walprotocol.h?rev=1.1&content-type=text/x-cvsweb-markup)
   
   

2. Re: [COMMITTERS] pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr()

   Fujii Masao <masao.fujii@gmail.com> — 2010-06-07T13:35:10Z

   On Fri, Jun 4, 2010 at 7:17 AM, Tom Lane <tgl@postgresql.org> wrote:
   > Log Message:
   > -----------
   > Add current WAL end (as seen by walsender, ie, GetWriteRecPtr() result)
   > and current server clock time to SR data messages.  These are not currently
   > used on the slave side but seem likely to be useful in future, and it'd be
   > better not to change the SR protocol after release.  Per discussion.
   > Also do some minor code review and cleanup on walsender.c, and improve the
   > protocol documentation.
   
   This commit changed walsender so that it doesn't call set_ps_display() if
   update_process_title = off. On the other hand, walreceiver doesn't check
   update_process_title. Though this check might not be required since it's
   within set_ps_display(), we should do that for the sake of consistency?
   I attached the patch.
   
   Regards,
   
   -- 
   Fujii Masao
   NIPPON TELEGRAPH AND TELEPHONE CORPORATION
   NTT Open Source Software Center
   

3. Re: Re: [COMMITTERS] pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr()

   Tom Lane <tgl@sss.pgh.pa.us> — 2010-06-07T15:45:18Z

   Fujii Masao <masao.fujii@gmail.com> writes:
   > This commit changed walsender so that it doesn't call set_ps_display() if
   > update_process_title = off.
   
   Yeah.  The idea is to not waste time on a useless snprintf() call when the
   GUC is turned off.
   
   > On the other hand, walreceiver doesn't check
   > update_process_title. Though this check might not be required since it's
   > within set_ps_display(), we should do that for the sake of consistency?
   
   Seems reasonable to make the same minor optimization on that side.
   Will commit.
   
   			regards, tom lane