Re: [COMMITTERS] pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr()

Fujii Masao <masao.fujii@gmail.com>

View thread

From: Fujii Masao <masao.fujii@gmail.com>

To: Tom Lane <tgl@postgresql.org>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2010-06-07T13:35:10Z

Lists: pgsql-hackers

Attachments

walrcv_update_process_title_v1.patch (application/octet-stream) patch v1

On Fri, Jun 4, 2010 at 7:17 AM, Tom Lane <tgl@postgresql.org> wrote:
> Log Message:
> -----------
> Add current WAL end (as seen by walsender, ie, GetWriteRecPtr() result)
> and current server clock time to SR data messages.  These are not currently
> used on the slave side but seem likely to be useful in future, and it'd be
> better not to change the SR protocol after release.  Per discussion.
> Also do some minor code review and cleanup on walsender.c, and improve the
> protocol documentation.

This commit changed walsender so that it doesn't call set_ps_display() if
update_process_title = off. On the other hand, walreceiver doesn't check
update_process_title. Though this check might not be required since it's
within set_ps_display(), we should do that for the sake of consistency?
I attached the patch.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center