Thread

1. Bug in parse_basebackup_options Re: [COMMITTERS] pgsql: Make walsender options order-independent

   Fujii Masao <masao.fujii@gmail.com> — 2011-01-25T09:32:11Z

   On Mon, Jan 24, 2011 at 7:41 AM, Magnus Hagander <magnus@hagander.net> wrote:
   > Make walsender options order-independent
   >
   > While doing this, also move base backup options into
   > a struct instead of increasing the number of parameters
   > to multiple functions for each new option.
   
   When I read the include-WAL-in-backup patch, I found that this
   commit had the bug; parse_basebackup_options fails in parsing
   options because of wrong usage of MemSet. Here is the patch.
   
   Regards,
   
   -- 
   Fujii Masao
   NIPPON TELEGRAPH AND TELEPHONE CORPORATION
   NTT Open Source Software Center
   

2. Re: Bug in parse_basebackup_options Re: [COMMITTERS] pgsql: Make walsender options order-independent

   Magnus Hagander <magnus@hagander.net> — 2011-01-25T09:51:01Z

   On Tue, Jan 25, 2011 at 10:32, Fujii Masao <masao.fujii@gmail.com> wrote:
   > On Mon, Jan 24, 2011 at 7:41 AM, Magnus Hagander <magnus@hagander.net> wrote:
   >> Make walsender options order-independent
   >>
   >> While doing this, also move base backup options into
   >> a struct instead of increasing the number of parameters
   >> to multiple functions for each new option.
   >
   > When I read the include-WAL-in-backup patch, I found that this
   > commit had the bug; parse_basebackup_options fails in parsing
   > options because of wrong usage of MemSet. Here is the patch.
   
   Wow. I know I fixed that at one point, it must've gone bad again in a
   merge. Interestingly enough it works in my environment, but that must
   be pure luck.
   
   So thanks - applied.
   
   -- 
    Magnus Hagander
    Me: http://www.hagander.net/
    Work: http://www.redpill-linpro.com/