Bug in parse_basebackup_options Re: [COMMITTERS] pgsql: Make walsender options order-independent

Fujii Masao <masao.fujii@gmail.com>

View thread

From: Fujii Masao <masao.fujii@gmail.com>

To: Magnus Hagander <magnus@hagander.net>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2011-01-25T09:32:11Z

Lists: pgsql-hackers

Attachments

parse_basebackup_options_bugfix_v1.patch (application/octet-stream) patch v1

On Mon, Jan 24, 2011 at 7:41 AM, Magnus Hagander <magnus@hagander.net> wrote:
> Make walsender options order-independent
>
> While doing this, also move base backup options into
> a struct instead of increasing the number of parameters
> to multiple functions for each new option.

When I read the include-WAL-in-backup patch, I found that this
commit had the bug; parse_basebackup_options fails in parsing
options because of wrong usage of MemSet. Here is the patch.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center