Horton

Thread

Commits

  1. Update comment for ReplicationSlot.last_saved_restart_lsn

  1. Document slot's restart_lsn can go backward

    Alexander Korotkov <aekorotkov@gmail.com> — 2025-07-18T11:40:49Z

    Hackers,

While working on the patch fixing the situation when slot's
restart_lsn ends up pointing to a removed WAL segment [1], we
discovered that sometimes slot's restart_lsn can go backward
[2][3][4].  Hayato Kuroda proposed a patch [5], which improves
comments by describing this behavior.  As proposed by Amit Kapila [6],
I'm starting a new thread about this comments patch.

Any feedback on this patch?

Links.
1. https://www.postgresql.org/message-id/1d12d2-67235980-35-19a406a0%4063439497
2. https://www.postgresql.org/message-id/OSCPR01MB1496646E4CF72B9231DB711AFF57DA%40OSCPR01MB14966.jpnprd01.prod.outlook.com
3. https://www.postgresql.org/message-id/CALDaNm1prhebmnAY_0%3D5UJ-WodSSbj6C8X-igrGa1EamtLw5BA%40mail.gmail.com
4. https://www.postgresql.org/message-id/CALDaNm34RtDat%2BkZE_1%2BCY86pDLJM18hxNRTZx3CCGE%3DaN%3D_%3DA%40mail.gmail.com
5. https://www.postgresql.org/message-id/OSCPR01MB1496634CF3BFEC3A491CF8111F547A%40OSCPR01MB14966.jpnprd01.prod.outlook.com
6. https://www.postgresql.org/message-id/CAA4eK1%2BqYg2nwa7TVz2xN-9FDZHLUGT7NLWHtfdeaf32KN3QEQ%40mail.gmail.com

------
Regards,
Alexander Korotkov
Supabase

  2. Re: Document slot's restart_lsn can go backward

    Alexander Korotkov <aekorotkov@gmail.com> — 2025-07-19T12:47:28Z

    On Fri, Jul 18, 2025 at 2:40 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> While working on the patch fixing the situation when slot's
> restart_lsn ends up pointing to a removed WAL segment [1], we
> discovered that sometimes slot's restart_lsn can go backward
> [2][3][4].  Hayato Kuroda proposed a patch [5], which improves
> comments by describing this behavior.  As proposed by Amit Kapila [6],
> I'm starting a new thread about this comments patch.
>
> Any feedback on this patch?

If nobody has additions/objections, I'll push this change.

------
Regards,
Alexander Korotkov
Supabase

  3. Re: Document slot's restart_lsn can go backward

    Amit Kapila <amit.kapila16@gmail.com> — 2025-07-21T05:34:15Z

    On Fri, Jul 18, 2025 at 5:11 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
>
> While working on the patch fixing the situation when slot's
> restart_lsn ends up pointing to a removed WAL segment [1], we
> discovered that sometimes slot's restart_lsn can go backward
> [2][3][4].  Hayato Kuroda proposed a patch [5], which improves
> comments by describing this behavior.  As proposed by Amit Kapila [6],
> I'm starting a new thread about this comments patch.
>
> Any feedback on this patch?
>

I have tried to slightly improve the comments. You can include the
suggestions, if you and/or kuroda-san thinks that the suggestions make
the patch better.

-- 
With Regards,
Amit Kapila.

  4. Re: Document slot's restart_lsn can go backward

    vignesh C <vignesh21@gmail.com> — 2025-07-21T08:40:00Z

    On Mon, 21 Jul 2025 at 11:04, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Jul 18, 2025 at 5:11 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> >
> > While working on the patch fixing the situation when slot's
> > restart_lsn ends up pointing to a removed WAL segment [1], we
> > discovered that sometimes slot's restart_lsn can go backward
> > [2][3][4].  Hayato Kuroda proposed a patch [5], which improves
> > comments by describing this behavior.  As proposed by Amit Kapila [6],
> > I'm starting a new thread about this comments patch.
> >
> > Any feedback on this patch?
> >
>
> I have tried to slightly improve the comments. You can include the
> suggestions, if you and/or kuroda-san thinks that the suggestions make
> the patch better.

Your changes look good to me.

Regards,
Vignesh

  5. Re: Document slot's restart_lsn can go backward

    Alexander Korotkov <aekorotkov@gmail.com> — 2025-07-21T12:09:05Z

    On Mon, Jul 21, 2025 at 11:40 AM vignesh C <vignesh21@gmail.com> wrote:
>
> On Mon, 21 Jul 2025 at 11:04, Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Fri, Jul 18, 2025 at 5:11 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> > >
> > > While working on the patch fixing the situation when slot's
> > > restart_lsn ends up pointing to a removed WAL segment [1], we
> > > discovered that sometimes slot's restart_lsn can go backward
> > > [2][3][4].  Hayato Kuroda proposed a patch [5], which improves
> > > comments by describing this behavior.  As proposed by Amit Kapila [6],
> > > I'm starting a new thread about this comments patch.
> > >
> > > Any feedback on this patch?
> > >
> >
> > I have tried to slightly improve the comments. You can include the
> > suggestions, if you and/or kuroda-san thinks that the suggestions make
> > the patch better.
>
> Your changes look good to me.

Pushed!
Thanks to everybody involved.

------
Regards,
Alexander Korotkov
Supabase