Re: Document slot's restart_lsn can go backward

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alexander Korotkov <aekorotkov@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-21T08:40:00Z
Lists: pgsql-hackers
On Mon, 21 Jul 2025 at 11:04, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Jul 18, 2025 at 5:11 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> >
> > While working on the patch fixing the situation when slot's
> > restart_lsn ends up pointing to a removed WAL segment [1], we
> > discovered that sometimes slot's restart_lsn can go backward
> > [2][3][4].  Hayato Kuroda proposed a patch [5], which improves
> > comments by describing this behavior.  As proposed by Amit Kapila [6],
> > I'm starting a new thread about this comments patch.
> >
> > Any feedback on this patch?
> >
>
> I have tried to slightly improve the comments. You can include the
> suggestions, if you and/or kuroda-san thinks that the suggestions make
> the patch better.

Your changes look good to me.

Regards,
Vignesh



Commits

  1. Update comment for ReplicationSlot.last_saved_restart_lsn