Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix typos in comments.

  1. Typo in comment for pgstat_database_flush_cb()

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2025-03-30T10:28:07Z

    Another thing I noticed is $SUBJECT: I think “if lock could not
immediately acquired” should be “if lock could not be immediately
acquired”.  Attached is a patch for that.

Best regards,
Etsuro Fujita

  2. Re: Typo in comment for pgstat_database_flush_cb()

    Tender Wang <tndrwang@gmail.com> — 2025-03-30T11:31:25Z

    Etsuro Fujita <etsuro.fujita@gmail.com> 于2025年3月30日周日 18:28写道：

> Another thing I noticed is $SUBJECT: I think “if lock could not
> immediately acquired” should be “if lock could not be immediately
> acquired”.  Attached is a patch for that.
>

Agree.
The patch looks good to me.


-- 
Thanks,
Tender Wang

  3. Re: Typo in comment for pgstat_database_flush_cb()

    Heikki Linnakangas <hlinnaka@iki.fi> — 2025-03-30T11:32:27Z

    On 30/03/2025 13:28, Etsuro Fujita wrote:
> Another thing I noticed is $SUBJECT: I think “if lock could not
> immediately acquired” should be “if lock could not be immediately
> acquired”.  Attached is a patch for that.

Yep. And there are more instances of the same typo in other such 
flush_cb functions, if you search for "immediately acquired".

-- 
Heikki Linnakangas
Neon (https://neon.tech)

  4. Re: Typo in comment for pgstat_database_flush_cb()

    Heikki Linnakangas <hlinnaka@iki.fi> — 2025-03-30T11:39:35Z

    On 30/03/2025 14:32, Heikki Linnakangas wrote:
> On 30/03/2025 13:28, Etsuro Fujita wrote:
>> Another thing I noticed is $SUBJECT: I think “if lock could not
>> immediately acquired” should be “if lock could not be immediately
>> acquired”.  Attached is a patch for that.
> 
> Yep. And there are more instances of the same typo in other such 
> flush_cb functions, if you search for "immediately acquired".

While we're at it, the comment feels a bit awkward to me anyway. Maybe 
rephrase it to "If nowait is true and the lock could not be immediately 
acquired, returns false without flushing the entry. Otherwise returns true."

-- 
Heikki Linnakangas
Neon (https://neon.tech)

  5. Re: Typo in comment for pgstat_database_flush_cb()

    Gurjeet Singh <gurjeet@singh.im> — 2025-03-30T17:54:08Z

    On Sun Mar 30, 2025 at 4:39 AM PDT, Heikki Linnakangas wrote:
> On 30/03/2025 14:32, Heikki Linnakangas wrote:
>> On 30/03/2025 13:28, Etsuro Fujita wrote:
>>> Another thing I noticed is $SUBJECT: I think “if lock could not
>>> immediately acquired” should be “if lock could not be immediately
>>> acquired”.  Attached is a patch for that.
>> 
>> Yep. And there are more instances of the same typo in other such 
>> flush_cb functions, if you search for "immediately acquired".

+1 for chainging other occurrences of this in other pgstat_*.c files.

> While we're at it, the comment feels a bit awkward to me anyway. Maybe 
> rephrase it to "If nowait is true and the lock could not be immediately 
> acquired, returns false without flushing the entry. Otherwise returns true."

This rephrasing does sounds better.

Best regards,
Gurjeet
http://Gurje.et

  6. Re: Typo in comment for pgstat_database_flush_cb()

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2025-04-06T11:31:50Z

    On Sun, Mar 30, 2025 at 7:54 PM Gurjeet Singh <gurjeet@singh.im> wrote:
> On Sun Mar 30, 2025 at 4:39 AM PDT, Heikki Linnakangas wrote:
> > On 30/03/2025 14:32, Heikki Linnakangas wrote:
> >> On 30/03/2025 13:28, Etsuro Fujita wrote:
> >>> Another thing I noticed is $SUBJECT: I think “if lock could not
> >>> immediately acquired” should be “if lock could not be immediately
> >>> acquired”.  Attached is a patch for that.
> >>
> >> Yep. And there are more instances of the same typo in other such
> >> flush_cb functions, if you search for "immediately acquired".
>
> +1 for chainging other occurrences of this in other pgstat_*.c files.
>
> > While we're at it, the comment feels a bit awkward to me anyway. Maybe
> > rephrase it to "If nowait is true and the lock could not be immediately
> > acquired, returns false without flushing the entry. Otherwise returns true."
>
> This rephrasing does sounds better.

+1 for both suggestions.  So I modified the comment as such in each
file with such a flush_cb function.  I will push the patch.

Thanks Heikki for the suggestions!  Thanks Gurjeet and Tender for the review!

Best regards,
Etsuro Fujita

  7. Re: Typo in comment for pgstat_database_flush_cb()

    Michael Paquier <michael@paquier.xyz> — 2025-04-06T21:44:31Z

    On Sun, Apr 06, 2025 at 01:31:50PM +0200, Etsuro Fujita wrote:
> +1 for both suggestions.  So I modified the comment as such in each
> file with such a flush_cb function.  I will push the patch.

Thanks for the fix.  Could you also backpatch that down to v15?  It
would be good to keep this level of comment documentation consistent
across all branches.
--
Michael

  8. Re: Typo in comment for pgstat_database_flush_cb()

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2025-04-07T09:50:40Z

    On Sun, Apr 6, 2025 at 11:44 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Sun, Apr 06, 2025 at 01:31:50PM +0200, Etsuro Fujita wrote:
> > +1 for both suggestions.  So I modified the comment as such in each
> > file with such a flush_cb function.  I will push the patch.
>
> Thanks for the fix.  Could you also backpatch that down to v15?  It
> would be good to keep this level of comment documentation consistent
> across all branches.

Sure, I will do that as well.

Best regards,
Etsuro Fujita

  9. Re: Typo in comment for pgstat_database_flush_cb()

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2025-05-03T11:15:47Z

    On Mon, Apr 7, 2025 at 6:50 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> On Sun, Apr 6, 2025 at 11:44 PM Michael Paquier <michael@paquier.xyz> wrote:
> > Could you also backpatch that down to v15?  It
> > would be good to keep this level of comment documentation consistent
> > across all branches.
>
> Sure, I will do that as well.

Pushed and back-patched.  It took me much longer than expected to
return to this.

Thanks!

Best regards,
Etsuro Fujita