Horton
Menu

Re: Typo in comment for pgstat_database_flush_cb()

Heikki Linnakangas <hlinnaka@iki.fi>

View thread
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Etsuro Fujita <etsuro.fujita@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-30T11:39:35Z
Lists: pgsql-hackers 
On 30/03/2025 14:32, Heikki Linnakangas wrote:
> On 30/03/2025 13:28, Etsuro Fujita wrote:
>> Another thing I noticed is $SUBJECT: I think “if lock could not
>> immediately acquired” should be “if lock could not be immediately
>> acquired”.  Attached is a patch for that.
> 
> Yep. And there are more instances of the same typo in other such 
> flush_cb functions, if you search for "immediately acquired".

While we're at it, the comment feels a bit awkward to me anyway. Maybe 
rephrase it to "If nowait is true and the lock could not be immediately 
acquired, returns false without flushing the entry. Otherwise returns true."

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix typos in comments.