Horton

Thread

Commits

  1. Fix thinko in comment.

  1. Multi-insert related comment in CopyFrom()

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2022-09-21T07:39:41Z

    Hi,

While working on the “Fast COPY FROM based on batch insert” patch, I
noticed this:

    else if (proute != NULL && resultRelInfo->ri_TrigDesc != NULL &&
             resultRelInfo->ri_TrigDesc->trig_insert_new_table)
    {
        /*
         * For partitioned tables we can't support multi-inserts when there
         * are any statement level insert triggers. It might be possible to
         * allow partitioned tables with such triggers in the future, but for
         * now, CopyMultiInsertInfoFlush expects that any before row insert
         * and statement level insert triggers are on the same relation.
         */
        insertMethod = CIM_SINGLE;
    }

I think there is a thinko in the comment; “before” should be after.
Patch attached.

Best regards,
Etsuro Fujita

  2. Re: Multi-insert related comment in CopyFrom()

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2022-09-22T07:11:29Z

    On Wed, Sep 21, 2022 at 4:39 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> While working on the “Fast COPY FROM based on batch insert” patch, I
> noticed this:
>
>     else if (proute != NULL && resultRelInfo->ri_TrigDesc != NULL &&
>              resultRelInfo->ri_TrigDesc->trig_insert_new_table)
>     {
>         /*
>          * For partitioned tables we can't support multi-inserts when there
>          * are any statement level insert triggers. It might be possible to
>          * allow partitioned tables with such triggers in the future, but for
>          * now, CopyMultiInsertInfoFlush expects that any before row insert
>          * and statement level insert triggers are on the same relation.
>          */
>         insertMethod = CIM_SINGLE;
>     }
>
> I think there is a thinko in the comment; “before” should be after.
> Patch attached.

Pushed.

Best regards,
Etsuro Fujita