Multi-insert related comment in CopyFrom()
Etsuro Fujita <etsuro.fujita@gmail.com>
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-09-21T07:39:41Z
Lists: pgsql-hackers
Attachments
- Fix-thinko-in-comment.patch (application/octet-stream) patch
Hi,
While working on the “Fast COPY FROM based on batch insert” patch, I
noticed this:
else if (proute != NULL && resultRelInfo->ri_TrigDesc != NULL &&
resultRelInfo->ri_TrigDesc->trig_insert_new_table)
{
/*
* For partitioned tables we can't support multi-inserts when there
* are any statement level insert triggers. It might be possible to
* allow partitioned tables with such triggers in the future, but for
* now, CopyMultiInsertInfoFlush expects that any before row insert
* and statement level insert triggers are on the same relation.
*/
insertMethod = CIM_SINGLE;
}
I think there is a thinko in the comment; “before” should be after.
Patch attached.
Best regards,
Etsuro Fujita
Commits
-
Fix thinko in comment.
- 6359e4b0fe71 12.13 landed
- 5f9dda4c0664 13.9 landed
- e4514aafad0b 14.6 landed
- 901ef14afe98 15.0 landed
- cbe6dd17ac45 16.0 landed