Horton

Thread

Commits

  1. Avoid redundant checks in partition_bounds_copy().

  1. Minor improvement to partition_bounds_copy()

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2020-02-20T11:36:10Z

    partition_bounds_copy() sets the hash_part and natts variable in each
iteration of a loop to copy the datums in the datums array, which
would not be efficient.  Attached is small patch for avoiding that.

Best regards,
Etsuro Fujita

  2. Re: Minor improvement to partition_bounds_copy()

    Amit Langote <amitlangote09@gmail.com> — 2020-02-20T12:38:26Z

    Fujita-san,

On Thu, Feb 20, 2020 at 8:36 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> partition_bounds_copy() sets the hash_part and natts variable in each
> iteration of a loop to copy the datums in the datums array, which
> would not be efficient.  Attached is small patch for avoiding that.

That looks good to me.

Thanks,
Amit

  3. Re: Minor improvement to partition_bounds_copy()

    Julien Rouhaud <rjuju123@gmail.com> — 2020-02-20T13:52:29Z

    On Thu, Feb 20, 2020 at 09:38:26PM +0900, Amit Langote wrote:
> Fujita-san,
>
> On Thu, Feb 20, 2020 at 8:36 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > partition_bounds_copy() sets the hash_part and natts variable in each
> > iteration of a loop to copy the datums in the datums array, which
> > would not be efficient.  Attached is small patch for avoiding that.
>
> That looks good to me.

Looks good to me too!

  4. Re: Minor improvement to partition_bounds_copy()

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2020-02-21T11:06:31Z

    On Thu, Feb 20, 2020 at 10:52 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
> On Thu, Feb 20, 2020 at 09:38:26PM +0900, Amit Langote wrote:
> > On Thu, Feb 20, 2020 at 8:36 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > > partition_bounds_copy() sets the hash_part and natts variable in each
> > > iteration of a loop to copy the datums in the datums array, which
> > > would not be efficient.  Attached is small patch for avoiding that.
> >
> > That looks good to me.
>
> Looks good to me too!

Pushed.  Thanks, Amit and Julien!

Best regards,
Etsuro Fujita