Horton

Re: Minor improvement to partition_bounds_copy()

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread View on postgr.es
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Amit Langote <amitlangote09@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-02-21T11:06:31Z
Lists: pgsql-hackers 
On Thu, Feb 20, 2020 at 10:52 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
> On Thu, Feb 20, 2020 at 09:38:26PM +0900, Amit Langote wrote:
> > On Thu, Feb 20, 2020 at 8:36 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > > partition_bounds_copy() sets the hash_part and natts variable in each
> > > iteration of a loop to copy the datums in the datums array, which
> > > would not be efficient.  Attached is small patch for avoiding that.
> >
> > That looks good to me.
>
> Looks good to me too!

Pushed.  Thanks, Amit and Julien!

Best regards,
Etsuro Fujita

Commits

  1. Avoid redundant checks in partition_bounds_copy().