Horton

Thread

Commits

  1. Remove incorrect file reference in comment.

  2. Move remaining code from tqual.[ch] to heapam.h / heapam_visibility.c.

  3. Move generic snapshot related code from tqual.h to snapmgr.h.

  1. Incorrect file reference in comment in procarray.c

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2023-11-02T12:40:35Z

    Hi,

While working on something else, I noticed $SUBJECT: commit b7eda3e0e
moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up
commit c91560def updated this reference incorrectly:

@@ -1498,7 +1498,7 @@ GetMaxSnapshotSubxidCount(void)
  * information may not be available.  If we find any overflowed subxid arrays,
  * we have to mark the snapshot's subxid data as overflowed, and extra work
  * *may* need to be done to determine what's running (see XidInMVCCSnapshot()
- * in tqual.c).
+ * in heapam_visibility.c).

Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/.

Best regards,
Etsuro Fujita

  2. Re: Incorrect file reference in comment in procarray.c

    Daniel Gustafsson <daniel@yesql.se> — 2023-11-02T13:20:55Z

    > On 2 Nov 2023, at 13:40, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:

> Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/.

No objections to the patch, the change is correct.  However, with git grep and
ctags and other ways of discovery I wonder if we're not better off avoiding
such references to filenames which are prone to going stale (and do from time
to time).

--
Daniel Gustafsson

  3. Re: Incorrect file reference in comment in procarray.c

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2023-11-03T09:53:57Z

    On Thu, Nov 2, 2023 at 10:20 PM Daniel Gustafsson <daniel@yesql.se> wrote:
> > On 2 Nov 2023, at 13:40, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/.
>
> No objections to the patch, the change is correct.  However, with git grep and
> ctags and other ways of discovery I wonder if we're not better off avoiding
> such references to filenames which are prone to going stale (and do from time
> to time).

Agreed.  As XidInMVCCSnapshot() is an extern function, such a tool
would allow the reader to easily find the source file that contains
the definition of that function.

Thanks for the comment!

Best regards,
Etsuro Fujita

  4. Re: Incorrect file reference in comment in procarray.c

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2023-11-13T10:20:43Z

    On Fri, Nov 3, 2023 at 6:53 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> On Thu, Nov 2, 2023 at 10:20 PM Daniel Gustafsson <daniel@yesql.se> wrote:
> > > On 2 Nov 2023, at 13:40, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > > Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/.
> >
> > No objections to the patch, the change is correct.  However, with git grep and
> > ctags and other ways of discovery I wonder if we're not better off avoiding
> > such references to filenames which are prone to going stale (and do from time
> > to time).
>
> Agreed.  As XidInMVCCSnapshot() is an extern function, such a tool
> would allow the reader to easily find the source file that contains
> the definition of that function.

Pushed, and back-patched, like that.

Best regards,
Etsuro Fujita